From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AB529EAE3 for ; Wed, 27 Sep 2023 12:49:05 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 85F86AF32 for ; Wed, 27 Sep 2023 12:48:35 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 27 Sep 2023 12:48:34 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 495A6474DA for ; Wed, 27 Sep 2023 12:48:34 +0200 (CEST) Date: Wed, 27 Sep 2023 12:48:26 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Gabriel Goller , Proxmox Backup Server development discussion References: <20230908114409.178087-1-g.goller@proxmox.com> <20230908114409.178087-2-g.goller@proxmox.com> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1695810472.h674oam6kl.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.063 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox v3] router: cli: added `ask_for_confirmation` helper X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Sep 2023 10:49:05 -0000 On September 27, 2023 12:13 pm, Wolfgang Bumiller wrote: > On Fri, Sep 08, 2023 at 01:44:09PM +0200, Gabriel Goller wrote: >> Added `ask_for_confirmation` helper that outputs a prompt and >> lets the user confirm or deny it. Also added localization using >> `libc::nl_langinfo()` to match/show a `yes` or `no` in the correct >> language. >> Implemented to close #4763. >>=20 >> Signed-off-by: Gabriel Goller >> --- >>=20 >> update v3: >> - added localization using `libc::nl_langinfo` >>=20 >> note: skipped to version 3, so that the whole patch series has=20 >> the same version number. >>=20 > [..] >> + use std::ffi::CStr; >> + let yes_expr =3D unsafe { CStr::from_ptr(libc::nl_langinfo(libc::YE= SEXPR)) } >> + .to_str() >> + .unwrap_or("^[yY]$"); >> + let no_expr =3D unsafe { CStr::from_ptr(libc::nl_langinfo(libc::NOE= XPR)) } >> + .to_str() >> + .unwrap_or("^[nN]$"); >> + >> + let n =3D no_expr.chars().find(|c| c.is_uppercase()).unwrap_or('N')= ; >> + let y =3D yes_expr.chars().find(|c| c.is_uppercase()).unwrap_or('Y'= ); >> + print!("{query} [{y}/{n}]: "); >=20 > Usually, the uppercase letter is used for the default for when typing > nothing, while the other one is lowercase. >=20 > Now I was also wondering what we should do if no upper/lowercase letter > exists, but then again, it seems yY and nN are pretty much always > included. I checked at least de_DE, ja_JP and zh_CN next to en_US, and > I'm fairly certain we can rely on that, since I'm assuming this is > exactly what `rpmatch(3)` does, which explicitly states that `y` and `n` > work regardless of locale. there definitely are locales that either don't include 'y' and/or 'n', or do so in a misleading manner. one example: $ LC_MESSAGES=3Dsw_KE.UTF-8 locale yesexpr ^[+1nNyY] $ LC_MESSAGES=3Dsw_KE.UTF-8 locale noexpr ^[-0hHlL] this is also the case for nl_langinfo, at least if the code in question actually calls setlocale/uselocale at some point, which we don't do I think? in any case, I am not sure whether localizing just the prompt answers makes much sense, if we don't localize log messages/CLI output/.. in general?