From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E91A598A16 for ; Mon, 17 Apr 2023 11:23:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D22F33A3D5 for ; Mon, 17 Apr 2023 11:23:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 17 Apr 2023 11:23:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D3F2645494 for ; Mon, 17 Apr 2023 11:23:51 +0200 (CEST) Date: Mon, 17 Apr 2023 11:23:38 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20230413154156.2304040-1-s.hanreich@proxmox.com> <20230413154156.2304040-3-s.hanreich@proxmox.com> In-Reply-To: <20230413154156.2304040-3-s.hanreich@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1681723228.1bz7zmrnt6.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.076 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 2/3] ui: sync job: add transfer-last parameter X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Apr 2023 09:23:53 -0000 works as expected, but looks a bit "jumpy" below the Ratelimit (since that has the Unit at the end). maybe it could be re-ordered, or even moved to the advanced section (until we have more snapshot filter options, at which point we might move it to a "Snapshot Filter" tab?). On April 13, 2023 5:41 pm, Stefan Hanreich wrote: > Signed-off-by: Stefan Hanreich > --- > www/config/SyncView.js | 9 ++++++++- > www/window/SyncJobEdit.js | 13 +++++++++++++ > 2 files changed, 21 insertions(+), 1 deletion(-) >=20 > diff --git a/www/config/SyncView.js b/www/config/SyncView.js > index a90e9a70..bf9072cb 100644 > --- a/www/config/SyncView.js > +++ b/www/config/SyncView.js > @@ -3,7 +3,7 @@ Ext.define('pbs-sync-jobs-status', { > fields: [ > 'id', 'owner', 'remote', 'remote-store', 'remote-ns', 'store', 'ns', > 'schedule', 'group-filter', 'next-run', 'last-run-upid', 'last-run-stat= e', > - 'last-run-endtime', > + 'last-run-endtime', 'transfer-last', > { > name: 'duration', > calculate: function(data) { > @@ -241,6 +241,13 @@ Ext.define('PBS.config.SyncJobView', { > renderer: v =3D> v ? Ext.String.htmlEncode(v) : gettext('All'), > width: 80, > }, > + { > + header: gettext('Transfer Last'), > + dataIndex: 'transfer-last', > + flex: 1, > + sortable: true, > + hidden: true, > + }, > { > header: gettext('Schedule'), > dataIndex: 'schedule', > diff --git a/www/window/SyncJobEdit.js b/www/window/SyncJobEdit.js > index 948ad5da..64447ebc 100644 > --- a/www/window/SyncJobEdit.js > +++ b/www/window/SyncJobEdit.js > @@ -131,6 +131,19 @@ Ext.define('PBS.window.SyncJobEdit', { > submitAutoScaledSizeUnit: true, > // NOTE: handle deleteEmpty in onGetValues due to bandwidth field hav= ing a cbind too > }, > + { > + fieldLabel: gettext('Transfer Last'), > + xtype: 'pbsPruneKeepInput', > + name: 'transfer-last', > + emptyText: gettext('all'), > + autoEl: { > + tag: 'div', > + 'data-qtip': gettext('The maximum amount of snapshots to be trans= ferred (per group)'), > + }, > + cbind: { > + deleteEmpty: '{!isCreate}', > + }, > + }, > ], > =20 > column2: [ > --=20 > 2.30.2 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20