From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D2D9F949B0 for ; Thu, 11 Apr 2024 09:19:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id AC82F1B228 for ; Thu, 11 Apr 2024 09:19:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 11 Apr 2024 09:19:14 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E732F44611 for ; Thu, 11 Apr 2024 09:19:13 +0200 (CEST) Date: Thu, 11 Apr 2024 09:19:13 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Hannes Laimer Message-ID: <1680475591.6047.1712819953060@webmail.proxmox.com> In-Reply-To: <20240409110012.166472-4-h.laimer@proxmox.com> References: <20240409110012.166472-1-h.laimer@proxmox.com> <20240409110012.166472-4-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev61 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.344 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, maintenance.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 03/24] maintenance: add 'Unpplugged' maintenance type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Apr 2024 07:19:45 -0000 Maybe a stupid question, but what is the purpose of this additional maintenance type? I can see that we get a different error message, but else it behaves the same as "Offline"? > On 9.4.2024 12:59 CEST Hannes Laimer wrote: > > > Signed-off-by: Hannes Laimer > --- > pbs-api-types/src/maintenance.rs | 31 +++++++++++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/pbs-api-types/src/maintenance.rs b/pbs-api-types/src/maintenance.rs > index a605cc17..e7ffbcd0 100644 > --- a/pbs-api-types/src/maintenance.rs > +++ b/pbs-api-types/src/maintenance.rs > @@ -38,7 +38,6 @@ pub enum Operation { > /// Maintenance type. > pub enum MaintenanceType { > // TODO: > - // - Add "unmounting" once we got pluggable datastores > // - Add "GarbageCollection" or "DeleteOnly" as type and track GC (or all deletes) as separate > // operation, so that one can enable a mode where nothing new can be added but stuff can be > // cleaned > @@ -48,6 +47,8 @@ pub enum MaintenanceType { > Offline, > /// The datastore is being deleted. > Delete, > + /// The removable datastore is unplugged > + Unplugged, > } > serde_plain::derive_display_from_serialize!(MaintenanceType); > serde_plain::derive_fromstr_from_deserialize!(MaintenanceType); > @@ -80,7 +81,7 @@ impl MaintenanceMode { > /// Used for deciding whether the datastore is cleared from the internal cache after the last > /// task finishes, so all open files are closed. > pub fn is_offline(&self) -> bool { > - self.ty == MaintenanceType::Offline > + self.ty == MaintenanceType::Offline || self.ty == MaintenanceType::Unplugged > } > > pub fn check(&self, operation: Option) -> Result<(), Error> { > @@ -96,6 +97,8 @@ impl MaintenanceMode { > return Ok(()); > } else if self.ty == MaintenanceType::Offline { > bail!("offline maintenance mode: {}", message); > + } else if self.ty == MaintenanceType::Unplugged { > + bail!("datastore is not plugged in"); > } else if self.ty == MaintenanceType::ReadOnly { > if let Some(Operation::Write) = operation { > bail!("read-only maintenance mode: {}", message); > @@ -104,3 +107,27 @@ impl MaintenanceMode { > Ok(()) > } > } > + > +#[test] > +fn test_check() { > + let ro_mode = MaintenanceMode::new(MaintenanceType::ReadOnly, None); > + let offline_mode = MaintenanceMode::new(MaintenanceType::Offline, None); > + let delete_mode = MaintenanceMode::new(MaintenanceType::Delete, None); > + let unplugged_mode = MaintenanceMode::new(MaintenanceType::Unplugged, None); > + > + assert!(ro_mode.check(Some(Operation::Lookup)).is_ok()); > + assert!(ro_mode.check(Some(Operation::Read)).is_ok()); > + assert!(ro_mode.check(Some(Operation::Write)).is_err()); > + > + assert!(offline_mode.check(Some(Operation::Lookup)).is_ok()); > + assert!(offline_mode.check(Some(Operation::Read)).is_err()); > + assert!(offline_mode.check(Some(Operation::Write)).is_err()); > + > + assert!(delete_mode.check(Some(Operation::Lookup)).is_err()); > + assert!(delete_mode.check(Some(Operation::Read)).is_err()); > + assert!(delete_mode.check(Some(Operation::Write)).is_err()); > + > + assert!(unplugged_mode.check(Some(Operation::Lookup)).is_ok()); > + assert!(unplugged_mode.check(Some(Operation::Read)).is_err()); > + assert!(unplugged_mode.check(Some(Operation::Write)).is_err()); > +} > -- > 2.39.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel