From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8F9EA95629 for ; Wed, 18 Jan 2023 12:14:00 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 737271F37D for ; Wed, 18 Jan 2023 12:14:00 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 18 Jan 2023 12:13:59 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6881444729 for ; Wed, 18 Jan 2023 12:13:59 +0100 (CET) Date: Wed, 18 Jan 2023 12:13:52 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20230118104903.441554-1-c.heiss@proxmox.com> <20230118104903.441554-3-c.heiss@proxmox.com> In-Reply-To: <20230118104903.441554-3-c.heiss@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.16.0 (https://github.com/astroidmail/astroid) Message-Id: <1674040346.a6cksp257q.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.134 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC PATCH proxmox-backup 2/6] client: Add `--protected` CLI flag to backup command X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jan 2023 11:14:00 -0000 On January 18, 2023 11:48 am, Christoph Heiss wrote: > Signed-off-by: Christoph Heiss > --- > proxmox-backup-client/src/main.rs | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/sr= c/main.rs > index 55198108..ee09db83 100644 > --- a/proxmox-backup-client/src/main.rs > +++ b/proxmox-backup-client/src/main.rs > @@ -663,6 +663,12 @@ fn spawn_catalog_upload( > optional: true, > default: false, > }, > + "protected": { > + type: Boolean, > + description: "Set backup as protected after upload.", > + optional: true, > + default: false, > + }, > } > } > )] > @@ -716,6 +722,7 @@ async fn create_backup( >=20 > let empty =3D Vec::new(); > let exclude_args =3D param["exclude"].as_array().unwrap_or(&empty); > + let protected =3D param["protected"].as_bool().unwrap_or(false); >=20 > let mut pattern_list =3D Vec::with_capacity(exclude_args.len()); > for entry in exclude_args { > @@ -1082,7 +1089,9 @@ async fn create_backup( > .upload_blob_from_data(manifest.into_bytes(), MANIFEST_BLOB_NAME= , options) > .await?; >=20 > - client.finish().await?; > + client.finish(Some(json!({ > + "protected": protected, > + }))).await?; this fails the backup with new client + --protected, at the very end, if th= e server doesn't have patch #1 of this series. we need some sort of compat mechanism... >=20 > let end_time =3D std::time::Instant::now(); > let elapsed =3D end_time.duration_since(start_time); > -- > 2.34.1 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20