From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id D90AE1FF17A for <inbox@lore.proxmox.com>; Mon, 5 Aug 2024 11:32:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2E54921A9; Mon, 5 Aug 2024 11:32:58 +0200 (CEST) Message-ID: <1662d9d4-d654-4bb6-a638-f8fa1317a603@proxmox.com> Date: Mon, 5 Aug 2024 11:32:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: pbs-devel@lists.proxmox.com References: <20240805092414.1178930-1-d.csapak@proxmox.com> <20240805092414.1178930-5-d.csapak@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <20240805092414.1178930-5-d.csapak@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 4/5] datastore: data blob: increase compression throughput X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Cc: Thomas Lamprecht <t.lamprecht@proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> On 8/5/24 11:24, Dominik Csapak wrote: > by not using `zstd::stream::copy_encode`, because that has an allocation > pattern that reduces throughput if the target/source storage and the > network are faster than the chunk creation. > > instead use `zstd_safe::compress` which shouldn't do any big > allocations, since we provide the target buffer. > > To handle the case that the target buffer is too small, we now ignore > all zstd error and continue with the uncompressed data, logging the error > except if the target buffer is too small. > > Some benchmarks on my machine from tmpfs to a datastore on tmpfs: > > Type without patches (MiB/s) with patches (MiB/s) > .img file ~614 ~767 > pxar one big file ~657 ~807 > pxar small files ~576 ~627 > > Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> @thomas sorry i forgot to adapt the commit message to your (or similar) suggestion feel free to either adapt it to your liking or telling me i should send a v4 for this ;) (which i'll happily do if you want) _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel