From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A9B17616E2 for ; Thu, 9 Jul 2020 14:22:38 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9E561123AB for ; Thu, 9 Jul 2020 14:22:38 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BF4BE1239E for ; Thu, 9 Jul 2020 14:22:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8E486430C4 for ; Thu, 9 Jul 2020 14:22:37 +0200 (CEST) Date: Thu, 9 Jul 2020 14:22:27 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Stefan Reiter Message-ID: <1652249703.373.1594297348205@webmail.proxmox.com> In-Reply-To: <20200709121242.26143-1-s.reiter@proxmox.com> References: <20200709121242.26143-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev15 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.033 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup-qemu] ignore missing or bad previous index X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2020 12:22:38 -0000 applied, thanks! > On 07/09/2020 2:12 PM Stefan Reiter wrote: > > > This is not a fatal condition, it just means that we cannot do > incremental backups client-side. This can happen if a new disk was added > the a VM since the last backup for example. > > Signed-off-by: Stefan Reiter > --- > src/commands.rs | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/src/commands.rs b/src/commands.rs > index 9c21702..6f26324 100644 > --- a/src/commands.rs > +++ b/src/commands.rs > @@ -114,7 +114,11 @@ pub(crate) async fn register_image( > > let index = match manifest { > Some(manifest) => { > - Some(client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await?) > + match client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await { > + Ok(index) => Some(index), > + // not having a previous index is not fatal, so ignore errors > + Err(_) => None > + } > }, > None => None > }; > -- > 2.20.1 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel