From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 358589EE8 for ; Wed, 27 Apr 2022 09:35:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 25349239F8 for ; Wed, 27 Apr 2022 09:35:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 5CA56239EF for ; Wed, 27 Apr 2022 09:35:21 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3160442DD3; Wed, 27 Apr 2022 09:35:21 +0200 (CEST) Date: Wed, 27 Apr 2022 09:35:14 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion , Roland Sturm References: <360557907.5748.1651033823899@webmail.proxmox.com> In-Reply-To: <360557907.5748.1651033823899@webmail.proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1651044569.oo1skrc0qp.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.171 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] PBS File Retore for NTFS with deduplication enabled leads to corrupted files X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Apr 2022 07:35:52 -0000 On April 27, 2022 6:30 am, Dietmar Maurer wrote: >> Think he would like to restore files from a windows Server (like a files= erver) with "Windows dedup" enabled on a volume. >> Win Dedup works with chunk-files in "System Volume Information" Folder a= nd metadatafiles to the "chunk-data". >>=20 >> We also use Win Dedup on File Servers >=20 > And you can reproduce the problem? >=20 see (German) https://forum.proxmox.com/threads/file-restore-dateien-defekt.= 108257 we could see whether ntfs-3g works better, but I am afraid from what I=20 read in their issues they are playing a bit of cat and mouse with=20 changes on the windows side, and the feature seems to not be backwards=20 compatible in the windows world either, so chances are it will work=20 better the older the VM's version of windows is. alternatively, we could try to detect deduplicated files in the=20 file-restore VM (based on some metadata?) and hard-fail the restore=20 instead of returning valid-looking garbage. users do report success with mapping + attaching the disk to an existing=20 (version-matching) windows VM for manual file-restoring, so we could=20 also think whether it's possible to streamline this approach somehow=20 ("attach disk RO from backup" on the PVE side?), since it's a lot more=20 flexible for other use cases as well (e.g., encrypted disks inside the=20 VM, storage management or FS we don't support in our file-restore VM,=20 FS features that are not available in our file-restore VM kernel (yet or=20 anymore ;)), ..). obviously an advanced use case, and for simple cases=20 the existing file-restore approach is far nicer UX-wise.