From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 5E3E285174 for ; Fri, 17 Dec 2021 10:51:04 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4947F29644 for ; Fri, 17 Dec 2021 10:50:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 787DB29638 for ; Fri, 17 Dec 2021 10:50:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1A191453A0 for ; Fri, 17 Dec 2021 10:50:33 +0100 (CET) Date: Fri, 17 Dec 2021 10:50:26 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20211216163109.11109-1-h.laimer@proxmox.com> In-Reply-To: <20211216163109.11109-1-h.laimer@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1639734347.z3e0ir7gr7.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.246 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_SHORT 0.001 Use of a URL Shortener for very short URL SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [node.rs, proxmox.com, docs.rs, proxmox-backup-proxy.rs, openssl.org, config.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup 0/3] close #3612: allow config of SSL cipher-suites for proxy X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Dec 2021 09:51:04 -0000 On December 16, 2021 5:31 pm, Hannes Laimer wrote: > Cannot be configured in the WebUI, only through proxmox-backup-manager, > api or in the config file directly(not recommended). For changes to take > effect the proxy has to be restarted. >=20 > Since the string can be rather long and I assume most of the time the > defaults are used, it is not in the WebUI. there are actually two different strings (unfortunately): cipher_list in OpenSSL parlance is for TLS <=3D 1.2 ciphersuites is for TLS 1.3 the format is not compatible, so we likely need to expose it as two=20 options (or two properties of a 'tls' option? if we also want to make=20 supported TLS versions configurable in the future for example that would=20 make sense). PVE currently only does the former via /etc/default/pveproxy, but I'll=20 send patches for that soon. for PBS we should support both from the=20 start, and take care not to mix up the terminology (that would confuse=20 users that already know about this weird API split). I'd also add the=20 relevant TLS version info into the option description ;) https://docs.rs/openssl/latest/openssl/ssl/struct.SslAcceptorBuilder.html#= method.set_ciphersuites https://www.openssl.org/docs/manmaster/man3/SSL_CTX_set_ciphersuites.html >=20 > Hannes Laimer (3): > config: add cipher-suites to NodeConfig > proxy: use ssl cipher-suites from config if set > api2: make cipher-suites updatable >=20 > src/api2/node/config.rs | 4 ++++ > src/bin/proxmox-backup-proxy.rs | 6 ++++++ > src/config/node.rs | 13 +++++++++++++ > 3 files changed, 23 insertions(+) >=20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20