From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B29C8BA374 for ; Tue, 19 Mar 2024 14:04:57 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 936E31F57D for ; Tue, 19 Mar 2024 14:04:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Tue, 19 Mar 2024 14:04:57 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BADFD46842 for ; Tue, 19 Mar 2024 14:04:56 +0100 (CET) Date: Tue, 19 Mar 2024 14:04:56 +0100 (CET) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Christian Ebner , Proxmox Backup Server development discussion Message-ID: <1636351248.13273.1710853496094@webmail.proxmox.com> In-Reply-To: <85dba1c8-bbbc-403a-87de-38889f713bd9@proxmox.com> References: <20240305092703.126906-1-c.ebner@proxmox.com> <20240305092703.126906-30-c.ebner@proxmox.com> <1710241045.h2ym0ilnyj.astroid@yuna.none> <85dba1c8-bbbc-403a-87de-38889f713bd9@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev59 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.064 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC v2 proxmox-backup 29/36] client: pxar: add previous reference to archiver X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Mar 2024 13:04:57 -0000 > Christian Ebner hat am 19.03.2024 13:59 CET geschri= eben: >=20 > =20 > On 3/12/24 13:12, Fabian Gr=C3=BCnbichler wrote: > > this reader should be started after the writer (else somebody else migh= t > > be -however unlikely- faster and the reader is no longer for the > > previous snapshot). > >=20 > > upside - it can then be moved into the download_previous_manifest arm, > > if the previous manifest was not downloadable using the writer, or the > > key changed, or something else -> we can already skip re-using it based > > on those facts. > The reason this is placed her (very inconveniently I know) is that the=20 > HttpClient is consumed by the BackupWriter instance, and I have to reuse > the same client (as otherwise I get locking issues). >=20 > Open for further discussion if there is a better way to handle this, I=20 > also would like to move this to the match arm for pxar backup creation=20 > if possible. BackupWriter::start could also take a reference to the HttpClient? it does = exactly the same things with it after all ;) maybe I am missing something..