From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 012366B57C for ; Mon, 20 Sep 2021 14:03:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id EDA5020B5F for ; Mon, 20 Sep 2021 14:03:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 327CB20B54 for ; Mon, 20 Sep 2021 14:03:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 065AE449A0 for ; Mon, 20 Sep 2021 14:03:26 +0200 (CEST) Date: Mon, 20 Sep 2021 14:03:19 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20210920091340.3251578-1-dietmar@proxmox.com> In-Reply-To: <20210920091340.3251578-1-dietmar@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1632134258.i0mkw8z4ep.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.356 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup rebase 01/15] start new pbs-server workspace X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Sep 2021 12:03:27 -0000 gave the whole series a quick go-over, looks okay to me and nothing in=20 the build output looks off. the proxmox-restore-daemon actually lost a=20 dependency thanks to the move (libstdc++), and relaxed its libc version=20 requirement (2.28 -> 2.18) :) sent a little bit of code duplication/missing features I noticed=20 separately on the affected patches. On September 20, 2021 11:13 am, Dietmar Maurer wrote: > --- > Cargo.toml | 2 ++ > Makefile | 1 + > pbs-server/Cargo.toml | 9 +++++++++ > pbs-server/src/lib.rs | 0 > 4 files changed, 12 insertions(+) > create mode 100644 pbs-server/Cargo.toml > create mode 100644 pbs-server/src/lib.rs >=20 > diff --git a/Cargo.toml b/Cargo.toml > index 72d786c9..58abf7c6 100644 > --- a/Cargo.toml > +++ b/Cargo.toml > @@ -26,6 +26,7 @@ members =3D [ > "pbs-datastore", > "pbs-fuse-loop", > "pbs-runtime", > + "pbs-server", > "pbs-systemd", > "pbs-tape", > "pbs-tools", > @@ -107,6 +108,7 @@ pbs-client =3D { path =3D "pbs-client" } > pbs-config =3D { path =3D "pbs-config" } > pbs-datastore =3D { path =3D "pbs-datastore" } > pbs-runtime =3D { path =3D "pbs-runtime" } > +pbs-server =3D { path =3D "pbs-server" } > pbs-systemd =3D { path =3D "pbs-systemd" } > pbs-tools =3D { path =3D "pbs-tools" } > pbs-tape =3D { path =3D "pbs-tape" } > diff --git a/Makefile b/Makefile > index e6c85a2e..050218ba 100644 > --- a/Makefile > +++ b/Makefile > @@ -39,6 +39,7 @@ SUBCRATES :=3D \ > pbs-datastore \ > pbs-fuse-loop \ > pbs-runtime \ > + pbs-server \ > pbs-systemd \ > pbs-tape \ > pbs-tools \ > diff --git a/pbs-server/Cargo.toml b/pbs-server/Cargo.toml > new file mode 100644 > index 00000000..e933c1e6 > --- /dev/null > +++ b/pbs-server/Cargo.toml > @@ -0,0 +1,9 @@ > +[package] > +name =3D "pbs-server" > +version =3D "0.1.0" > +authors =3D ["Proxmox Support Team "] > +edition =3D "2018" > +description =3D "REST server implementation" > + > +[dependencies] > +anyhow =3D "1.0" > diff --git a/pbs-server/src/lib.rs b/pbs-server/src/lib.rs > new file mode 100644 > index 00000000..e69de29b > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20