From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6605B6A3C5 for ; Thu, 16 Sep 2021 12:08:51 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 641D323B90 for ; Thu, 16 Sep 2021 12:08:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 9E03423B85 for ; Thu, 16 Sep 2021 12:08:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 75A9C448DF for ; Thu, 16 Sep 2021 12:08:50 +0200 (CEST) Date: Thu, 16 Sep 2021 12:08:43 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20210906105755.2651203-1-d.csapak@proxmox.com> In-Reply-To: <<20210906105755.2651203-1-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1631786578.ohqxliw46l.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.363 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/12] add 'protected' setting for snapshots X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 10:08:51 -0000 general looks okay, needs a rebase (so not tested, just read ;)) a few smaller notes on indivual patches On September 6, 2021 12:57 pm, Dominik Csapak wrote: > add the means to 'protect' a snapshot against pruning and removal by > adding a file '.protected' in the snapshot folder >=20 > changes from rfc: > * added gui parts > * added tests > * fixed a bug (that the test uncovered) > * add pbs client command > * prevent removal (also during sync) >=20 > Dominik Csapak (12): > pbs-datastore: add protection info to BackupInfo > pbs-datastore: skip protected backups in pruning > add protected info of snapshots to api and task logs > tests/prune: add tests for protecteded backups > backup/datastore: prevent protected snapshots to be removed > pull_store/group: dont try remove locally protected snapshots > api2: datastore/delete_group: throw error for partially removed group > api2/admin/datastore: add get/set_protection > proxmox-backup-client: add 'protected update command' > ui: PruneInputPanel: add keepReason 'protected' for protected backups > ui: add protected icon to snapshots > fix #3602: ui: datastore/Content: add action to set protection status >=20 > pbs-api-types/src/lib.rs | 2 + > pbs-datastore/src/backup_info.rs | 20 ++++- > pbs-datastore/src/prune.rs | 17 ++-- > proxmox-backup-client/src/snapshot.rs | 51 +++++++++++ > src/api2/admin/datastore.rs | 116 +++++++++++++++++++++++++- > src/backup/datastore.rs | 37 +++++--- > src/server/prune_job.rs | 4 +- > src/server/pull.rs | 19 ++++- > tests/prune.rs | 40 ++++++++- > www/datastore/Content.js | 75 +++++++++++++++++ > www/datastore/Prune.js | 4 + > 11 files changed, 355 insertions(+), 30 deletions(-) >=20 > --=20 > 2.30.2 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20