From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C33A06A335 for ; Thu, 16 Sep 2021 09:58:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B31FF21B20 for ; Thu, 16 Sep 2021 09:58:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1EE2B21B15 for ; Thu, 16 Sep 2021 09:58:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CFCC3448DC for ; Thu, 16 Sep 2021 09:58:01 +0200 (CEST) Date: Thu, 16 Sep 2021 09:57:55 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20210915134157.19762-1-f.gruenbichler@proxmox.com> <20210915134157.19762-7-f.gruenbichler@proxmox.com> <3411c837-865e-4f66-04e4-05e93b37c6c0@proxmox.com> <5ba7b5b3-3ab0-e7e8-3cb7-fe0c28b01ce9@proxmox.com> In-Reply-To: <5ba7b5b3-3ab0-e7e8-3cb7-fe0c28b01ce9@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1631778363.a4s2m09ziw.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.371 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [pve-devel] [PATCH v2 proxmox-backup 06/10] sync: add group filtering X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2021 07:58:02 -0000 On September 16, 2021 9:38 am, Thomas Lamprecht wrote: > On 16.09.21 09:19, Thomas Lamprecht wrote: >>> if we want to make this configurable over the GUI, we probably want= to switch >>> the job edit window to a tabpanel and add a second grid tab for sel= ecting >>> the groups >> we could also get away by adding it in the advanced section for now. >=20 > I had a quick talk with Dominik which noticed me that there can be a list= of filters. >=20 > So a separate tab-panel would seem OK to me. For UX I'd could imagine hav= ing a > "Add Filter" button that'd work out similarly to how we have the knet lin= k add in PVE > cluster creation nowadays. In addition to that a preview window would be = nice to have, > maybe similar to the "Prune now" one, but we only need the backup-groups = here not the > full list of snapshots, so it would be relatively cheap to get. >=20 yeah, that was kind of what I was going for - but with the added=20 complexity of having different filter types with different=20 "completion"/selection mechanisms - the type filter has three static choices - the regex is freeform (but maybe a dropdown with some common=20 suggestions would be nice? those could also live in the docs though) - the group filter has a list of existing groups on the remote end to=20 choose from, but also requires freeform entry as option (a group might=20 not exist yet, or not exist any longer, but still needs to be filtered=20 for in the sync job, either to catch the group when it has been=20 created, or to clean it up when it was previously synced, or just for=20 handling the currently set filters correctly) the last part I tried when writing v1, and it was quite the mess=20 (Dominik's suggestion back then was to move it to a tab with a grid=20 view, because the combobox selector was too limited IIRC). a preview/dry-run for pull/sync would be nice in general, and shouldn't=20 be too hard to add. it would need to run in a worker though (as it needs=20 to query remote and local groups to decide what would be synced, even if=20 the bulk work of actually downloading chunks is skipped). it could be=20 done with the pull API without persisting the sync config, as those line=20 up 1:1. a preview of just the filterung with the already available (cached)=20 remote groups is of course instant. could even be done GUI-side I guess,=20 since the current filters are quite trivial to re-implement there. not=20 sure how to fit that inside the already big dialogue tab though ;)