From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0750C68CB4 for ; Fri, 23 Jul 2021 08:17:29 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F00E318716 for ; Fri, 23 Jul 2021 08:17:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 2633618708 for ; Fri, 23 Jul 2021 08:17:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E5AD44255E for ; Fri, 23 Jul 2021 08:17:26 +0200 (CEST) Date: Fri, 23 Jul 2021 08:17:17 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Dietmar Maurer , Proxmox Backup Server development discussion References: <1240918108.626.1626968790003@webmail.proxmox.com> In-Reply-To: <1240918108.626.1626968790003@webmail.proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1627020655.mumlv0buee.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.444 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 7/7] manager: don't complete sync job ID on creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Jul 2021 06:17:29 -0000 On July 22, 2021 5:46 pm, Dietmar Maurer wrote: >> On 07/22/2021 4:35 PM Fabian Gr=C3=BCnbichler wrote: >>=20 >> =20 >> that does not make sense,=20 >=20 > make sense to me, ack, maybe that was a bit strongly worded ;) >> since re-using an existing one leads to an >> error. >=20 > because it really helps to see what already exists >=20 we don't have that semantic for other completions though, and for sync=20 jobs most users will have auto-generated names if they created their=20 jobs with the GUI.. creating a datastore does not complete existing=20 names, updating/showing/removing/using does. creating a new remote does=20 not complete existing remote names, updating/showing/removing/using one=20 does. same for users, API tokens - the only other exception that=20 completes on creation is adding a new network interface. but I don't have strong feelings about this (I literally stumbled upon=20 this when doing the other patches) - other than that we should be=20 consistent. so if we agree that we want to complete existing identifiers=20 when adding new entities, I'd send a separate series adding that to the=20 others where it's missing.