From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9B73F72964 for ; Fri, 2 Jul 2021 14:40:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 901E18F9C for ; Fri, 2 Jul 2021 14:40:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E90DD8F89 for ; Fri, 2 Jul 2021 14:40:05 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B34DE40540 for ; Fri, 2 Jul 2021 14:40:05 +0200 (CEST) Date: Fri, 02 Jul 2021 14:39:58 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20210630155759.1894155-1-s.reiter@proxmox.com> In-Reply-To: <20210630155759.1894155-1-s.reiter@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1625229020.brdiyhyox3.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.553 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, api.rs, build-initramfs.sh, disk.rs] Subject: Re: [pbs-devel] [PATCH 0/5] Add LVM (thin) support for single file restore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Jul 2021 12:40:07 -0000 Reviewed-By: Fabian Gr=C3=BCnbichler requires a Breaks on the old restore image (else the restore daemon=20 crashes because of missing lock/LVM support). some potential for follow-ups/issues I encountered with a not-so-fast=20 PBS instance and bigger VMs: - increase VM start timeout (currently 12s?), as the initial scan of=20 disks seems to block responding to the startup status request, and=20 scanning all VGs/LVs can take quite a lot longer than that -=20 alternatively, fix this blockage and/or consider VM started sooner? - filter out "known unreadable" LVs, like Ceph (bluestore) OSDs - investigate '--sysinit' option for lvchange/vgchange (seems=20 appropriate for what we are doing inside the VM ;)) - investigate '-K' to allow looking at "non-auto-activatable" LVs and as discussed off-list, I think we should switch to=20 build-dependencies and copying binaries+needed libs in=20 build-initramfs.sh instead of downloading .deb packages and extracting=20 them only to remove part of their contents again - but that is firmly in=20 "improve/cleanup build" territory, so lower priority than the above. On June 30, 2021 5:57 pm, Stefan Reiter wrote: > Uses LVM tools to support LVM(-thin) volumes in the single-file restore d= aemon. > Tested with multi-disk LVs, thinpools and different filesystems on top of= them. >=20 > Note for testing: The current proxmox-backup git master will not work for > building the proxmox-restore-daemon binary, as the OpenID changes pull in= some > library dependencies not available in the restore VM. >=20 >=20 > proxmox-backup-restore-image: Stefan Reiter (1): > add LVM (thin) tooling >=20 > src/build_initramfs.sh | 6 ++++++ > src/config-base | 1 + > 2 files changed, 7 insertions(+) >=20 > proxmox-backup: Stefan Reiter (4): > file-restore-daemon/disk: dedup BucketComponents and make size > optional > file-restore-daemon/disk: fix component path errors > file-restore-daemon/disk: ignore already-mounted error and prefix > zpool > file-restore-daemon/disk: add LVM (thin) support >=20 > src/bin/proxmox_restore_daemon/api.rs | 2 +- > src/bin/proxmox_restore_daemon/disk.rs | 222 +++++++++++++++++++++++-- > 2 files changed, 208 insertions(+), 16 deletions(-) >=20 > --=20 > 2.30.2 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20