From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6FECC717C2 for ; Tue, 29 Jun 2021 11:50:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 68398C2F2 for ; Tue, 29 Jun 2021 11:50:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8F8D2C2E5 for ; Tue, 29 Jun 2021 11:50:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 5D01E467D9 for ; Tue, 29 Jun 2021 11:50:18 +0200 (CEST) Date: Tue, 29 Jun 2021 11:50:10 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20210625092050.2329182-1-dietmar@proxmox.com> In-Reply-To: <20210625092050.2329182-1-dietmar@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1624959349.llg6xqufc6.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.437 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment POISEN_SPAM_PILL 0.1 Meta: its spam POISEN_SPAM_PILL_1 0.1 random spam to be learned in bayes POISEN_SPAM_PILL_3 0.1 random spam to be learned in bayes SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [domain.rs, user.rs, mod.rs, tools.rs, memcom.rs, proxmox-backup-manager.rs, openid.rs, domains.rs, acl.rs, proxmox.com, config.rs, access.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup v3 00/10] OpenID connect realms X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jun 2021 09:50:20 -0000 seems to work okay in general (and looks okay code-wise), some missing=20 pieces: - proxmox-openid-rs prints some information that looks like debug (full=20 returned info from provider) - user-attr in proxmox-backup like in PVE - GUI: user adding/editing needs some adaptation for openid (e.g., removing= a=20 user prints a warning about unknown realm, but removes it anyway,=20 adding a user has no realm selection and requires a password) - GUI: realm adding/editing is missing altogether the check_acl_path change could be split and folded into the patches=20 that first use that ACL path, but no hard feelings there.. the last patch probably requires some in-depth review, I only took a=20 cursory glance (and it could be ordered before the patch with the fixme=20 that it fixes) On June 25, 2021 11:20 am, Dietmar Maurer wrote: > This implements OpenID connect realms using the new > "proxmox-openid-rs" crate. >=20 > Note: The new src/tools/memcom.rs is from Wolfgang. >=20 > Changes since v2: > fix CachedUserInfo by using a shared memory version counter >=20 > Changes since v1: > - really fix commit message of first patch > - change api endpoints (/access/openid/{login|auth-url}) > - merged all api implementation patches >=20 > Changes since preview version (for Fabian): > - fix commit message > - reserve namen 'pam' and 'pbs' > - fix 'make deb' >=20 >=20 > Dietmar Maurer (10): > depend on proxmox-openid-rs > config: new domains.cfg to configure openid realm > check_acl_path: add /access/domains and /access/openid > add API to manage openid realms > cli: add CLI to manage openid realms. > implement new helper is_active_user_id() > cleanup user/token is_active() check > api: add openid redirect/login API > ui: implement OpenId login > fix CachedUserInfo by using a shared memory version counter >=20 > Cargo.toml | 2 + > src/api2/access.rs | 4 +- > src/api2/access/domain.rs | 18 ++ > src/api2/access/openid.rs | 190 ++++++++++++++++ > src/api2/config/access/mod.rs | 8 +- > src/api2/config/access/openid.rs | 274 +++++++++++++++++++++++ > src/bin/proxmox-backup-manager.rs | 1 + > src/bin/proxmox_backup_manager/mod.rs | 2 + > src/bin/proxmox_backup_manager/openid.rs | 99 ++++++++ > src/config.rs | 1 + > src/config/acl.rs | 8 +- > src/config/cached_user_info.rs | 48 ++-- > src/config/domains.rs | 173 ++++++++++++++ > src/config/user.rs | 38 ++++ > src/tools.rs | 3 + > src/tools/memcom.rs | 159 +++++++++++++ > www/Application.js | 8 +- > www/LoginView.js | 100 ++++++++- > www/Utils.js | 8 + > 19 files changed, 1115 insertions(+), 29 deletions(-) > create mode 100644 src/api2/access/openid.rs > create mode 100644 src/api2/config/access/openid.rs > create mode 100644 src/bin/proxmox_backup_manager/openid.rs > create mode 100644 src/config/domains.rs > create mode 100644 src/tools/memcom.rs >=20 > --=20 > 2.30.2 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20