From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3E4BA74EC5 for ; Fri, 4 Jun 2021 10:21:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2D1721A93A for ; Fri, 4 Jun 2021 10:21:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id D7CF61A92C for ; Fri, 4 Jun 2021 10:21:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A8C744279A for ; Fri, 4 Jun 2021 10:21:24 +0200 (CEST) Date: Fri, 04 Jun 2021 10:21:17 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20210604071625.4811-1-d.csapak@proxmox.com> In-Reply-To: <20210604071625.4811-1-d.csapak@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1622794517.ypqwqri9n2.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.017 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, pull.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] client/pull: log snapshots that are skipped because of time X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jun 2021 08:21:59 -0000 On June 4, 2021 9:16 am, Dominik Csapak wrote: > we skip snapshots that are older than the last sync-time, > log that so the user can know why it is not synced well, technically last sync is a bit of a misnomer here anyway, since it=20 could also just be last backup made directly to the target datastore. we=20 might want to make this behaviour more explicit as well? or allow=20 marking groups/datastore as "sync target" to prevent manual backups from=20 interfering with syncs? >=20 > Signed-off-by: Dominik Csapak > --- > src/client/pull.rs | 6 ++++++ > 1 file changed, 6 insertions(+) >=20 > diff --git a/src/client/pull.rs b/src/client/pull.rs > index 95720973..96414a7a 100644 > --- a/src/client/pull.rs > +++ b/src/client/pull.rs > @@ -14,6 +14,7 @@ use crate::{ > backup::*, > client::*, > server::WorkerTask, > + task_log, > tools::{compute_file_csum, ParallelHandler}, > }; > use proxmox::api::error::{HttpError, StatusCode}; > @@ -495,6 +496,11 @@ pub async fn pull_group( > =20 > if let Some(last_sync_time) =3D last_sync { > if last_sync_time > backup_time { > + task_log!( > + worker, > + "skipping snapshot {} - older than last sync", > + snapshot > + ); adding this would mean that sync logs would grow and grow and grow over=20 time.. maybe a single: skipped 32 remote snapshots (2021-MM-DDTHH:MM::SSZ..2021-MM-DDTHH:MM::SSZ) = older than newest local snapshot. it would mean only adding a single line to the output, but contains=20 almost all the information? > continue; > } > } > --=20 > 2.20.1 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20