From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3D66662FB8 for ; Tue, 24 Nov 2020 16:44:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3776E10000 for ; Tue, 24 Nov 2020 16:44:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 27F09FFF4 for ; Tue, 24 Nov 2020 16:44:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E220E424C0 for ; Tue, 24 Nov 2020 16:44:27 +0100 (CET) Date: Tue, 24 Nov 2020 16:44:20 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Dietmar Maurer , Proxmox Backup Server development discussion References: <20201124130520.1058725-1-f.gruenbichler@proxmox.com> <20201124130520.1058725-2-f.gruenbichler@proxmox.com> <1970589785.367.1606232217036@webmail.proxmox.com> In-Reply-To: <1970589785.367.1606232217036@webmail.proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1606232547.d9bn5hfnnr.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup-qemu 1/2] encryption key tracking: use fingerprint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Nov 2020 15:44:29 -0000 On November 24, 2020 4:36 pm, Dietmar Maurer wrote: > Does this improve something? I can't see the purpose of this change. it allows use to display this remembered fingerprint (e.g., in the=20 'invalidating bitmap' message or via the WIP 'query-proxmox-support'. (also, I'd rather harmonize this now while PVE->PBS is still in beta,=20 and not afterwards) >> @@ -152,7 +154,8 @@ pub(crate) fn check_last_encryption_key( >> let digest_guard =3D PREVIOUS_CRYPT_CONFIG_DIGEST.lock().unwrap(); >> match (*digest_guard, config) { >> (Some(last_digest), Some(current_config)) =3D> { >> - crypt_config_digest(current_config) =3D=3D last_digest >> + current_config.fingerprint().bytes() =3D=3D &last_digest >> + || crypt_config_digest(current_config) =3D=3D last_dige= st >> }, >> (None, None) =3D> true, >> _ =3D> false, >> @@ -440,7 +443,13 @@ pub(crate) async fn finish_backup( >> =20 >> { >> let crypt_config_digest =3D match crypt_config { >> - Some(current_config) =3D> Some(crypt_config_digest(current_= config)), >> + Some(current_config) =3D> { >> + let fp =3D current_config >> + .fingerprint() >> + .bytes() >> + .to_owned(); >> + Some(fp) >> + }, >> None =3D> None, >> }; >> >=20 =