From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D39B864452 for ; Fri, 30 Oct 2020 09:04:25 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BEB02FB43 for ; Fri, 30 Oct 2020 09:03:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4E51BFB38 for ; Fri, 30 Oct 2020 09:03:55 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1D95D45984 for ; Fri, 30 Oct 2020 09:03:55 +0100 (CET) Date: Fri, 30 Oct 2020 09:03:48 +0100 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion , Thomas Lamprecht References: <20201028113632.814586-1-f.gruenbichler@proxmox.com> In-Reply-To: MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1604044834.4pcbf9rinm.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 00/16] API tokens X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Oct 2020 08:04:25 -0000 On October 29, 2020 8:50 pm, Thomas Lamprecht wrote: > On 28.10.20 12:36, Fabian Gr=C3=BCnbichler wrote: >> changes since RFC: >> - reworked Userid with wrapping Authid >> - rename RpcEnvironment user -> auth_id >> - lots of churn >> - lots of corner cases >> - lots of rebasing >> - ACL editing for unprivileged users >> - more GUI stuff added >>=20 >> proxmox and proxmox-widget-toolkit patches needed for patches #3++ and >> GUI respectively >>=20 >=20 > played a bit around, works nice in general, but please add some documenta= tion, > else one can have a bit of a hard time figuring the usage out. yes, docs and some more improvements are on my todo list. > Also, I just may not remember if we discussed this, but why is there no > "inherit the user permission" mode like PVE has? because with the ACL changes (allowing a user to define arbitrary ACLs=20 for their tokens) it's not really needed. I can just give Admin on '/'=20 with propagation for the same effect. and also because I think it's=20 better to make users think about which permissions to give a certain=20 token (e.g., most tokens will probably just have Datastore.Backup on one=20 datastore, which is something I'd like to put somewhere on the Datastore=20 GUI as a two-step 'Create client token' thing) then nudging them into=20 'just tick this and everything works (but is not much better than just=20 storing your username + password everywhere)'. =