From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D7BC761AE5 for ; Thu, 22 Oct 2020 10:19:22 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C363C1E52C for ; Thu, 22 Oct 2020 10:18:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 29EF31E520 for ; Thu, 22 Oct 2020 10:18:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E2FE445ED4 for ; Thu, 22 Oct 2020 10:18:50 +0200 (CEST) Date: Thu, 22 Oct 2020 10:18:42 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Proxmox Backup Server development discussion References: <20201005145703.26529-1-t.lamprecht@proxmox.com> <3c7181e5-9e21-9071-cfd5-dd97884e024e@proxmox.com> In-Reply-To: <3c7181e5-9e21-9071-cfd5-dd97884e024e@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1603354658.wifegpzioo.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.030 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, api2.rs, ping.rs] Subject: Re: [pbs-devel] [PATCH backup] api: add world accessible ping dummy endpoint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Oct 2020 08:19:22 -0000 On October 21, 2020 8:32 pm, Thomas Lamprecht wrote: > On 05.10.20 16:57, Thomas Lamprecht wrote: >> This is indented to be used for the PVE storage library, replacing >> the missuse of the much more expensive status API call. >>=20 >> Signed-off-by: Thomas Lamprecht >> --- >>=20 >> I initially thought about adding this to the proxmox-backup-client as co= mmand, >> but it's not much of use there (user can just use the version command) a= nd for >> the PVE integration we can do a simple http request with LWP, which is m= uch >> cheaper than fork+exec the client there. >>=20 >=20 > any objections to this? Else I'd apply it as is.. LGTM, maybe besides that having a separate file for this instead of just=20 inlining it into api2.rs seems overkill :-P >=20 >> src/api2.rs | 2 ++ >> src/api2/ping.rs | 29 +++++++++++++++++++++++++++++ >> 2 files changed, 31 insertions(+) >> create mode 100644 src/api2/ping.rs >>=20 >> diff --git a/src/api2.rs b/src/api2.rs >> index 85d29ed2..27ef2975 100644 >> --- a/src/api2.rs >> +++ b/src/api2.rs >> @@ -7,6 +7,7 @@ pub mod reader; >> pub mod status; >> pub mod types; >> pub mod version; >> +pub mod ping; >> pub mod pull; >> mod helpers; >> =20 >> @@ -22,6 +23,7 @@ pub const SUBDIRS: SubdirMap =3D &[ >> ("backup", &backup::ROUTER), >> ("config", &config::ROUTER), >> ("nodes", &NODES_ROUTER), >> + ("ping", &ping::ROUTER), >> ("pull", &pull::ROUTER), >> ("reader", &reader::ROUTER), >> ("status", &status::ROUTER), >> diff --git a/src/api2/ping.rs b/src/api2/ping.rs >> new file mode 100644 >> index 00000000..087b1377 >> --- /dev/null >> +++ b/src/api2/ping.rs >> @@ -0,0 +1,29 @@ >> +use anyhow::{Error}; >> +use serde_json::{json, Value}; >> + >> +use proxmox::api::{api, Router, Permission}; >> + >> +#[api( >> + returns: { >> + description: "Dummy ping", >> + type: Object, >> + properties: { >> + pong: { >> + description: "Always true", >> + type: bool, >> + } >> + } >> + }, >> + access: { >> + description: "Anyone can access this, because it's used for a c= heap check if the API daemon is online.", >> + permission: &Permission::World, >> + } >> +)] >> +/// Dummy method which replies with `{ "pong": True }` >> +fn ping() -> Result { >> + Ok(json!({ >> + "pong": true, >> + })) >> +} >> +pub const ROUTER: Router =3D Router::new() >> + .get(&API_METHOD_PING); >>=20 >=20 >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20 =