From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A81E0693C4 for ; Wed, 5 Aug 2020 12:12:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 91E56137F2 for ; Wed, 5 Aug 2020 12:11:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id BA4FD137E5 for ; Wed, 5 Aug 2020 12:11:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 86CCF434A3 for ; Wed, 5 Aug 2020 12:11:48 +0200 (CEST) Date: Wed, 05 Aug 2020 12:11:37 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= To: Oguz Bektas , Proxmox Backup Server development discussion References: <20200804140136.1203818-1-o.bektas@proxmox.com> <129568827.330.1596603028183@webmail.proxmox.com> In-Reply-To: <129568827.330.1596603028183@webmail.proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.15.0 (https://github.com/astroidmail/astroid) Message-Id: <1596622203.98gp6kwkr5.astroid@nora.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.360 Adjusted score from AWL reputation of From: address KAM_ASCII_DIVIDERS 0.8 Spam that uses ascii formatting tricks KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, datastore.rs] Subject: Re: [pbs-devel] [PATCH backup] fix #2909: handle missing chunks gracefully in garbage collection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 10:12:20 -0000 On August 5, 2020 6:50 am, Dietmar Maurer wrote: > But now the task finish with status Ok? >=20 > IMHO, this is a serious problem... > for verify this should cause the task to fail, but for GC I am not so=20 sure. the garbage collection itself is fine (by definition, any missing=20 chunk the GC encounters is one that should not be garbage collected), it=20 just found an unrelated problem? >> On 08/04/2020 4:01 PM Oguz Bektas wrote: >>=20 >> =20 >> instead of bailing and stopping the entire GC process, log the missing >> chunk errors and continue. >>=20 >> Signed-off-by: Oguz Bektas >> --- >> src/backup/datastore.rs | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >>=20 >> diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs >> index ffd64b81..063fba53 100644 >> --- a/src/backup/datastore.rs >> +++ b/src/backup/datastore.rs >> @@ -436,8 +436,8 @@ impl DataStore { >> tools::fail_on_shutdown()?; >> let digest =3D index.index_digest(pos).unwrap(); >> if let Err(err) =3D self.chunk_store.touch_chunk(digest) { >> - bail!("unable to access chunk {}, required by {:?} - {}= ", >> - proxmox::tools::digest_to_hex(digest), file_name,= err); >> + worker.log(&format!("warning: unable to access chunk {}= , required by {:?} - {}", >> + proxmox::tools::digest_to_hex(digest), file_name,= err)); >> } >> } >> Ok(()) >> --=20 >> 2.20.1 >>=20 >>=20 >> _______________________________________________ >> pbs-devel mailing list >> pbs-devel@lists.proxmox.com >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel >=20 >=20 >=20 =