From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id D8AFA74935 for ; Mon, 19 Apr 2021 14:10:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id C35651598C for ; Mon, 19 Apr 2021 14:10:02 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id ED0AD1597E for ; Mon, 19 Apr 2021 14:09:58 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B018E45AB8 for ; Mon, 19 Apr 2021 14:09:58 +0200 (CEST) Date: Mon, 19 Apr 2021 14:09:37 +0200 (CEST) From: Wolfgang Bumiller To: Thomas Lamprecht , Proxmox Backup Server development discussion , Dominik Csapak Message-ID: <1564315045.4060.1618834178000@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev5 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.032 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup v2 03/14] tape/drive: clippy fixes X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Apr 2021 12:10:02 -0000 > On 04/19/2021 11:40 AM Thomas Lamprecht wrote: > > > On 19.04.21 10:38, Wolfgang Bumiller wrote: > >> if let Some(buffer_mode) = buffer_mode { > >> - let mut mode = head.flags3 & 0b1_000_1111; > >> + let mut mode = head.flags3 & 0b1000_1111; > > ^ I really wish those bits were documented or `bitflags!`, because maybe the 1/3/4 grouping is based on meaning :S > > But since it's not, I agree with this hunk ;-) > > But it is though, they are from the SCSI reference > "Mode Parameter Header for Mode Select" > > +--+--+--+--+--+--+--+--+ > |WP| B.MODE | SPEED | > +--+--+--+--+--+--+--+--+ > > (write protect, buffer mode, speed) > > so this is the wrong solution, the right one would be: > * keep as is > * introduce constant like BUFFER_MODE_MASK 0b01110000 and use it negated here ^ So let's do this then. I do think this particular lint is the least useful one TBH. When working on embedded riscv code I was pretty much constantly fighting with it... And maybe when the base is done we should also go through all the data structures and add doc comments referencing the corresponding scsi documentation to make it easier to navigate?