From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3AD2971500 for ; Thu, 8 Apr 2021 08:01:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2BE0216874 for ; Thu, 8 Apr 2021 08:01:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1CE6E16863 for ; Thu, 8 Apr 2021 08:01:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E08F8459E7 for ; Thu, 8 Apr 2021 08:01:50 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Reply-To: Proxmox Backup Server development discussion References: <20210212084016.27413-1-d.csapak@proxmox.com> Message-ID: <145a5803-69cc-8a37-b100-99aeaeee1aa1@proxmox.com> Date: Thu, 8 Apr 2021 08:01:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210212084016.27413-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.169 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [email.rs] Subject: Re: [pbs-devel] [PATCH proxmox] fix #3302: allow more characters for email X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Apr 2021 06:01:52 -0000 any comment? we should really allow at least '_' and '+' in addition On 2/12/21 9:40 AM, Dominik Csapak wrote: > change to something similar as in pve-common > word characters, +, -, ~ and . for the local part > > Signed-off-by: Dominik Csapak > --- > proxmox/src/tools/email.rs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/proxmox/src/tools/email.rs b/proxmox/src/tools/email.rs > index b5d42c4..c6336f4 100644 > --- a/proxmox/src/tools/email.rs > +++ b/proxmox/src/tools/email.rs > @@ -16,7 +16,7 @@ pub fn sendmail( > mailfrom: Option<&str>, > author: Option<&str>, > ) -> Result<(), Error> { > - let mail_regex = regex::Regex::new(r"^[a-zA-Z\.0-9-]+@[a-zA-Z\.0-9-]+$").unwrap(); > + let mail_regex = regex::Regex::new(r"^[\w\+\-\~\.]+@[a-zA-Z\.0-9-]+$").unwrap(); > > if mailto.is_empty() { > bail!("At least one recipient has to be specified!") >