From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Backup Server development discussion
<pbs-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pbs-devel] applied: [PATCH proxmox v2] fix #5868: rest-server: connection: fix busy waiting on closed connections pre tls
Date: Thu, 14 Nov 2024 15:21:45 +0100 [thread overview]
Message-ID: <145720f3-ca29-4b93-8e00-d08dc11576a3@proxmox.com> (raw)
In-Reply-To: <20241113103937.1554474-1-d.csapak@proxmox.com>
Am 13.11.24 um 11:39 schrieb Dominik Csapak:
> when a connection is closed before we have enough data to determine
> if it's tls or not, the socket stays in a readable state.
>
> Sadly, the tokio timeout we use here gets starved by the async_io
> callback.
>
> To fix this, save the amount of bytes peek returned and if they did not
> change between invocations of the callback, we assume that the
> connection was closed and exit with an error.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> changes from v1:
> * removed leftover unrelated test code
> * fixed up the commit message with the bug #
>
> proxmox-rest-server/src/connection.rs | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
>
applied this as stop-gap, thanks!
Like I mentioned off-list, I changed the error to ConnectionAborted and reworded
the commit message a bit.
_______________________________________________
pbs-devel mailing list
pbs-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
prev parent reply other threads:[~2024-11-14 14:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 10:39 [pbs-devel] " Dominik Csapak
2024-11-14 14:21 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=145720f3-ca29-4b93-8e00-d08dc11576a3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pbs-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox