From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 524DE636A8 for ; Tue, 22 Dec 2020 13:33:42 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3F8662C21B for ; Tue, 22 Dec 2020 13:33:12 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 749E32C20E for ; Tue, 22 Dec 2020 13:33:11 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 37133455D6 for ; Tue, 22 Dec 2020 13:33:11 +0100 (CET) Date: Tue, 22 Dec 2020 13:32:42 +0100 (CET) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Stefan Reiter Message-ID: <144907618.2193.1608640363259@webmail.proxmox.com> In-Reply-To: <20201221135611.14456-1-s.reiter@proxmox.com> References: <20201221135611.14456-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev14 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.110 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [mod.rs, future.rs, proxmox.com] Subject: [pbs-devel] applied: [RFC 0/2] backup client: implement some HTTP timeouts X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Dec 2020 12:33:42 -0000 applied > On 12/21/2020 2:56 PM Stefan Reiter wrote: > > > Not a comprehensive overhaul, but should fix the most common hangs to at least > finish *sometime*. Tested on an intentionally slow PBS with VM backups - QEMU > still hangs, but resumes to work after 20 seconds as intended. > > 20 seconds was chosen by fair dice roll, seems to be a good limit for opening an > HTTP connection (so not counting actual data transfer)? > > Disclaimer: The 'proxmox' patches were a *bit* over my head, so I hope the > generics and stuff make sense, appreciate any feedback there - it's certainly > interesting to play with higher-level Rust like this, would love to learn :) > > > proxmox: Stefan Reiter (1): > add tools::future with TimeoutFutureExt > > proxmox/src/tools/future.rs | 48 +++++++++++++++++++++++++++++++++++++ > proxmox/src/tools/mod.rs | 1 + > 2 files changed, 49 insertions(+) > create mode 100644 proxmox/src/tools/future.rs > > proxmox-backup: Stefan Reiter (1): > http_client: add timeouts for critical connects > > src/client/http_client.rs | 17 ++++++++++++++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > -- > 2.20.1 > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel