From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 401F1D0FB for ; Thu, 14 Apr 2022 09:50:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 28C1D2886B for ; Thu, 14 Apr 2022 09:50:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0F8232885D for ; Thu, 14 Apr 2022 09:50:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D18F040506 for ; Thu, 14 Apr 2022 09:50:21 +0200 (CEST) Message-ID: <1424ba39-b244-f0ca-fc51-fb0048892a8c@proxmox.com> Date: Thu, 14 Apr 2022 09:50:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:100.0) Gecko/20100101 Thunderbird/100.0 Content-Language: en-US To: Proxmox Backup Server development discussion , Markus Frank References: <20220413093005.61074-1-m.frank@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20220413093005.61074-1-m.frank@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [drive.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] proxmox-tape: api: restore_key-code moved to tape-encryption-keys X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Apr 2022 07:50:53 -0000 On 13.04.22 11:30, Markus Frank wrote: > The restore_key api-endpoint is tape/drive/{drive}/restore-key. > Since I cannot set the url parameter for the drivename to null or > undefined, when restoring by exported-key, I moved the > added restore_key-api-code to > "create_key aka POST api2/json/config/tape-encryption-keys" and > added an ApiHandler call in the cli's "restore_key" to call > "create_key" in the api. > > Signed-off-by: Markus Frank > --- > src/api2/config/tape_encryption_keys.rs | 39 ++++++++++++++++--- > src/api2/tape/drive.rs | 51 +++++++------------------ > src/bin/proxmox_tape/encryption_key.rs | 19 ++++++--- > 3 files changed, 61 insertions(+), 48 deletions(-) > > applied, thanks! Fixed the falsely required KDF param if a key was passed in a followup, together with some cleanups.