From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pbs-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id D04521FF16B for <inbox@lore.proxmox.com>; Thu, 20 Mar 2025 16:35:20 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 42BBE6957; Thu, 20 Mar 2025 16:35:20 +0100 (CET) Date: Thu, 20 Mar 2025 16:34:45 +0100 (CET) From: Christian Ebner <c.ebner@proxmox.com> To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, Hannes Laimer <h.laimer@proxmox.com> Message-ID: <1345010253.943.1742484885722@webmail.proxmox.com> In-Reply-To: <20250320121125.114333-1-h.laimer@proxmox.com> References: <20250320121125.114333-1-h.laimer@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev74 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.031 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] api: config: use guard for unmounting on failed datastore creation X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" <pbs-devel-bounces@lists.proxmox.com> > On 20.03.2025 13:11 CET Hannes Laimer <h.laimer@proxmox.com> wrote: > > > Currently if any `?`/`bail!` happens between mounting and completing > the creation process unmounting will be skipped. Adding this guard > solves that problem and makes it easier to add things in the future > without having to worry about a disk not being unmounted in case of a > failed creation. > > Signed-off-by: Hannes Laimer <h.laimer@proxmox.com> > Reported-by: Wolfgang Bumiller <w.bumiller@proxmox.com> > --- Thanks, this patch will come in handy here [0]. Tested creating new datastore on ext3 -> fails Tested reusing pre-existing datastore with corrupt folder structure -> fails Tested moving and replacing the datastore config while datastore creattion, so that writing the config will fail by `mv datastore.cfg datastore.cfg.old && mkdir datastore.cfg` -> fails For all 3 cases the removable datastore backing device is correctly unmounted after failure. Therefore please consider this: Tested-by: Christian Ebner <c.ebner@proxmox.com> [0] https://lore.proxmox.com/pbs-devel/20250320131711.312894-6-c.ebner@proxmox.com/ _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel