From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id A05791FF15C for ; Wed, 18 Sep 2024 10:54:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4A27D31EA4; Wed, 18 Sep 2024 10:54:26 +0200 (CEST) Date: Wed, 18 Sep 2024 10:54:23 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Christian Ebner Message-ID: <1307326024.1083.1726649663326@webmail.proxmox.com> In-Reply-To: <4611dc8b-ed62-47bd-a4b5-11e76459b299@proxmox.com> References: <20240913135944.317298-1-c.ebner@proxmox.com> <1902796862.144.1726241034647@webmail.proxmox.com> <27cfdbaa-eb6d-4585-a339-5640cf2ac323@proxmox.com> <4611dc8b-ed62-47bd-a4b5-11e76459b299@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev68 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.346 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC proxmox-backup] fix #5710: api: backup: stat known chunks during backup X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" > For this case, the index is initially copied over from the previous > snapshot and chunk digests inserted into the known chunks hashmap. > On client side, only changed chunks are uploaded via the backup api, and > inserted in the fixed index on the corresponding index position. The > information which previously indexed chunk it replaced is however lacking. > > Because of this, I currently tend to rather not modify the current > behavior and stat all of the known chunks. > > Any thoughts on this? Is there a better approach I currently am failing > to see? No, sorry. But Gabriel pointed out that this will have a negligible effect in most cases, so we can keep the current code if too difficult to implement. _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel