From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0B4A2BA4C3 for ; Thu, 14 Dec 2023 09:18:26 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D9E2913F8F for ; Thu, 14 Dec 2023 09:18:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 14 Dec 2023 09:18:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E09F47366 for ; Thu, 14 Dec 2023 09:18:25 +0100 (CET) Date: Thu, 14 Dec 2023 09:18:24 +0100 (CET) From: Dietmar Maurer To: Dominik Csapak , Thomas Lamprecht , Proxmox Backup Server development discussion Message-ID: <1297224291.1791.1702541904341@webmail.proxmox.com> In-Reply-To: References: <20231213101112.76140-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev56 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.363 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup] tape: fix 'eject-before-unload' api type X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Dec 2023 08:18:26 -0000 > mhmm i modeled it after the 'tuning' options of the datastore. Which is also clumsy and not really required... I would have used normal options instead... > maybe it was named badly, and the 'options' should be replaced by > 'quirks' (as in, changer quirks that only some people need, like > the datastore tuning options) > > but if you both want a more straight forward option directly in > the changer config, then it's also fine with me (i just > did not want to pollute the changer config with rather > specific quirk workarounds, and I doubt this is > the last of them, even though we don't see such things often) The changer config only has a few option, so we are far away from a polluted config. > just tell me if i should rename it to something else (like quirks) > or if i should put it directly in the changer config, and i'll send > the patches for it + docs update Yes, please use normal options unless there is a real requirement to use a property string.