From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 02569692D7 for ; Wed, 5 Aug 2020 06:51:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DBCC711271 for ; Wed, 5 Aug 2020 06:50:37 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 3FF5C11260 for ; Wed, 5 Aug 2020 06:50:36 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0E66F43494 for ; Wed, 5 Aug 2020 06:50:36 +0200 (CEST) Date: Wed, 5 Aug 2020 06:50:27 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Oguz Bektas Message-ID: <129568827.330.1596603028183@webmail.proxmox.com> In-Reply-To: <20200804140136.1203818-1-o.bektas@proxmox.com> References: <20200804140136.1203818-1-o.bektas@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev19 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.106 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, datastore.rs] Subject: Re: [pbs-devel] [PATCH backup] fix #2909: handle missing chunks gracefully in garbage collection X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Aug 2020 04:51:08 -0000 But now the task finish with status Ok? IMHO, this is a serious problem... > On 08/04/2020 4:01 PM Oguz Bektas wrote: > > > instead of bailing and stopping the entire GC process, log the missing > chunk errors and continue. > > Signed-off-by: Oguz Bektas > --- > src/backup/datastore.rs | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs > index ffd64b81..063fba53 100644 > --- a/src/backup/datastore.rs > +++ b/src/backup/datastore.rs > @@ -436,8 +436,8 @@ impl DataStore { > tools::fail_on_shutdown()?; > let digest = index.index_digest(pos).unwrap(); > if let Err(err) = self.chunk_store.touch_chunk(digest) { > - bail!("unable to access chunk {}, required by {:?} - {}", > - proxmox::tools::digest_to_hex(digest), file_name, err); > + worker.log(&format!("warning: unable to access chunk {}, required by {:?} - {}", > + proxmox::tools::digest_to_hex(digest), file_name, err)); > } > } > Ok(()) > -- > 2.20.1 > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel