From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <c.ebner@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 7376FAC0F
 for <pbs-devel@lists.proxmox.com>; Wed, 28 Jun 2023 11:43:37 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 5512F20AA5
 for <pbs-devel@lists.proxmox.com>; Wed, 28 Jun 2023 11:43:37 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Wed, 28 Jun 2023 11:43:36 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6E21440A7B
 for <pbs-devel@lists.proxmox.com>; Wed, 28 Jun 2023 11:43:36 +0200 (CEST)
Date: Wed, 28 Jun 2023 11:43:35 +0200 (CEST)
From: Christian Ebner <c.ebner@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <1291632408.2514.1687945415631@webmail.proxmox.com>
In-Reply-To: <d9b76624-42e2-22de-5586-f55480c417c5@proxmox.com>
References: <20230628081005.48122-1-c.ebner@proxmox.com>
 <d9b76624-42e2-22de-5586-f55480c417c5@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev47
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.004 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH backup stable-2] pbs2to3: add upgrade
 checker binary
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 28 Jun 2023 09:43:37 -0000

Thanks for the review, I will send the v2 with comments taken into consideration.

Cheers,
Chris

> On 28.06.2023 10:59 CEST Fiona Ebner <f.ebner@proxmox.com> wrote:
> 
>  
> Am 28.06.23 um 10:10 schrieb Christian Ebner:
> > Adds the pbs2to3 upgrade checker with some basic checks.
> > 
> > Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> 
> Some things I noticed:
> 
> > * chrony (Default in new Proxmox VE installations)
> 
> Should be "Proxmox Backup Server installations"
> 
> For repository checking, likely it's better to only check the suites of
> enabled repositories and only the 'deb' ones (not 'deb-src').
> 
> My
> deb http://deb.debian.org/debian-debug bullseye-debug main contrib
> line produces:
> NOTICE: found unusual suite 'debug', neighter old 'bullseye' nor new
> 'bookworm'..
> but the suite is 'bullseye-debug'.