From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6A99860952 for ; Thu, 10 Sep 2020 07:03:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5980917DF2 for ; Thu, 10 Sep 2020 07:03:09 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A6B4717DE2 for ; Thu, 10 Sep 2020 07:03:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 66D2A44AC9 for ; Thu, 10 Sep 2020 07:03:07 +0200 (CEST) Date: Thu, 10 Sep 2020 07:02:22 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Stefan Reiter Message-ID: <1289824957.1093.1599714142805@webmail.proxmox.com> In-Reply-To: <20200908132944.5876-2-s.reiter@proxmox.com> References: <20200908132944.5876-1-s.reiter@proxmox.com> <20200908132944.5876-2-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.3-Rev21 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, backup.rs] Subject: Re: [pbs-devel] [PATCH RESEND proxmox-backup 2/3] backup: check verify state of previous backup before allowing reuse X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Sep 2020 05:03:09 -0000 > On 09/08/2020 3:29 PM Stefan Reiter wrote: > > > Do not allow clients to reuse chunks from the previous backup if it has > a failed validation result. This would result in a new "successful" > backup that potentially references broken chunks. This patch does not prevent that, because in create_fixed_index(): let last_backup = match &env.last_backup { Some(info) => info, None => { bail!("cannot reuse index - no previous backup exists"); } }; So we allow reuse there! I suggest to do those checks earlier in upgrade_to_backup_protocol() > > If the previous backup has not been verified, assume it is fine and > continue on. > > Signed-off-by: Stefan Reiter > --- > > Patch 3 is much more useful with this one applied first, so here it is again > instead of a ping for easy review/application :) > > src/api2/backup.rs | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/src/api2/backup.rs b/src/api2/backup.rs > index ad608d85..c0b1d985 100644 > --- a/src/api2/backup.rs > +++ b/src/api2/backup.rs > @@ -652,6 +652,19 @@ fn download_previous( > None => bail!("no previous backup"), > }; > > + let (manifest, _) = env.datastore.load_manifest(&last_backup.backup_dir)?; > + let verify = manifest.unprotected["verify_state"].clone(); > + match serde_json::from_value::(verify) { > + Ok(verify) => { > + if verify.state != "ok" { > + bail!("previous backup has failed verification"); > + } > + }, > + Err(_) => { > + // no verify state found, ignore and treat as valid > + } > + }; > + > let mut path = env.datastore.snapshot_path(&last_backup.backup_dir); > path.push(&archive_name); > > -- > 2.20.1 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel