From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id DAF919F4FD for ; Mon, 6 Nov 2023 11:36:23 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id BC12514B90 for ; Mon, 6 Nov 2023 11:36:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 6 Nov 2023 11:36:22 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0ADEE45B9F for ; Mon, 6 Nov 2023 11:36:22 +0100 (CET) Date: Mon, 6 Nov 2023 11:36:20 +0100 (CET) From: Christian Ebner To: Proxmox Backup Server development discussion , Maximiliano Sandoval , Thomas Lamprecht Message-ID: <1281900928.721.1699266980870@webmail.proxmox.com> In-Reply-To: References: <20231103151707.191010-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev54 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.070 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC proxmox-backup 1/2] datastore: Allow encoding with a set compression level X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Nov 2023 10:36:23 -0000 > On 06.11.2023 11:12 CET Maximiliano Sandoval wrote: > > > Thomas Lamprecht writes: > > > On 03/11/2023 16:17, Maximiliano Sandoval R wrote: > >> We replace the boolean flag with an enum. > >> > > > > so what levels did you test (with what test cases), which difference > > in size was seen, any runtime impacts ...? > > I tested with the Linux kernel source from `git clone --depth=1` as of > d2f51b3516dade79269ff45eae2a7668ae711b25 and the COCO dataset (2017 > validation set) with no compression, and zstd levels 1,3, and 5. > > The output is > > ``` > $ ./target/debug/proxmox-backup-client backup --compression=none root.pxar:PATH/linux --repository=pbs:linux-none > Starting backup: host/hostname/2023-11-06T09:53:33Z > Client name: hostname > Starting backup protocol: Mon Nov 6 10:53:35 2023 > No previous manifest available. > Upload directory 'PATH/linux' to 'pbs:linux-none' as root.pxar.didx > root.pxar: had to backup 1.55 GiB of 1.55 GiB (compressed 1.55 GiB) in 119.67s > root.pxar: average backup speed: 13.265 MiB/s > Uploaded backup catalog (1.802 MiB) > Duration: 126.73s > End Time: Mon Nov 6 10:55:42 2023 > I would suggest to perform all tests with the binaries compiled in release mode again, otherwise you might loose out on a lot of compile time optimizations. > $ ./target/debug/proxmox-backup-client backup --compression=zstd,1 root.pxar:PATH/linux --repository=pbs:linux-zstd1 > Starting backup: host/hostname/2023-11-06T09:56:14Z > Client name: hostname > Starting backup protocol: Mon Nov 6 10:56:14 2023 > No previous manifest available. > Upload directory 'PATH/linux' to 'pbs:linux-zstd1' as root.pxar.didx > root.pxar: had to backup 1.55 GiB of 1.55 GiB (compressed 475.468 MiB) in 118.96s > root.pxar: average backup speed: 13.345 MiB/s > Uploaded backup catalog (1.802 MiB) > Duration: 120.80s > End Time: Mon Nov 6 10:58:15 2023 > > $ ./target/debug/proxmox-backup-client backup --compression=zstd,3 root.pxar:PATH/linux --repository=pbs:linux-zstd3 > Starting backup: host/hostname/2023-11-06T09:59:13Z > Client name: hostname > Starting backup protocol: Mon Nov 6 10:59:13 2023 > No previous manifest available. > Upload directory 'PATH/linux' to 'pbs:linux-zstd3' as root.pxar.didx > root.pxar: had to backup 1.55 GiB of 1.55 GiB (compressed 449.656 MiB) in 119.39s > root.pxar: average backup speed: 13.297 MiB/s > Uploaded backup catalog (1.802 MiB) > Duration: 120.78s > End Time: Mon Nov 6 11:01:13 2023 > > $ ./target/debug/proxmox-backup-client backup --compression=zstd,5 root.pxar:PATH/linux --repository=pbs:linux-zstd5 > Starting backup: host/hostname/2023-11-06T10:01:24Z > Client name: hostname > Starting backup protocol: Mon Nov 6 11:01:24 2023 > No previous manifest available. > Upload directory 'PATH/linux' to 'pbs:linux-zstd5' as root.pxar.didx > root.pxar: had to backup 1.55 GiB of 1.55 GiB (compressed 429.919 MiB) in 119.99s > root.pxar: average backup speed: 13.23 MiB/s > Uploaded backup catalog (1.802 MiB) > Duration: 121.30s > End Time: Mon Nov 6 11:03:25 2023 > > $ ./target/debug/proxmox-backup-client backup --compression=none root.pxar:PATH/val2017 --repository=pbs:coco-none > Starting backup: host/hostname/2023-11-06T10:04:28Z > Client name: hostname > Starting backup protocol: Mon Nov 6 11:04:28 2023 > No previous manifest available. > Upload directory 'PATH/val2017' to 'pbs:coco-none' as root.pxar.didx > root.pxar: had to backup 777.579 MiB of 777.579 MiB (compressed 777.581 MiB) in 58.80s > root.pxar: average backup speed: 13.223 MiB/s > Uploaded backup catalog (126.99 KiB) > Duration: 65.13s > End Time: Mon Nov 6 11:05:33 2023 > > $ ./target/debug/proxmox-backup-client backup --compression=zstd,1 root.pxar:PATH/val2017 --repository=pbs:coco-zstd1 > Starting backup: host/hostname/2023-11-06T10:06:40Z > Client name: hostname > Starting backup protocol: Mon Nov 6 11:06:40 2023 > No previous manifest available. > Upload directory 'PATH/val2017' to 'pbs:coco-zstd1' as root.pxar.didx > root.pxar: had to backup 777.579 MiB of 777.579 MiB (compressed 772.769 MiB) in 58.54s > root.pxar: average backup speed: 13.284 MiB/s > Uploaded backup catalog (126.99 KiB) > Duration: 64.88s > End Time: Mon Nov 6 11:07:45 2023 > > $ ./target/debug/proxmox-backup-client backup --compression=zstd,3 root.pxar:PATH/val2017 --repository=pbs:coco-zstd3 > Starting backup: host/hostname/2023-11-06T10:07:54Z > Client name: hostname > Starting backup protocol: Mon Nov 6 11:07:54 2023 > No previous manifest available. > Upload directory 'PATH/val2017' to 'pbs:coco-zstd3' as root.pxar.didx > root.pxar: had to backup 777.579 MiB of 777.579 MiB (compressed 770.425 MiB) in 58.70s > root.pxar: average backup speed: 13.247 MiB/s > Uploaded backup catalog (126.99 KiB) > Duration: 64.85s > End Time: Mon Nov 6 11:08:59 2023 > > $ ./target/debug/proxmox-backup-client backup --compression=zstd,5 root.pxar:PATH/val2017 --repository=pbs:coco-zstd5 > Starting backup: host/hostname/2023-11-06T10:09:12Z > Client name: hostname > Starting backup protocol: Mon Nov 6 11:09:13 2023 > No previous manifest available. > Upload directory 'PATH/val2017' to 'pbs:coco-zstd5' as root.pxar.didx > root.pxar: had to backup 777.579 MiB of 777.579 MiB (compressed 770.388 MiB) in 59.20s > root.pxar: average backup speed: 13.134 MiB/s > Uploaded backup catalog (126.99 KiB) > Duration: 65.24s > End Time: Mon Nov 6 11:10:18 2023 > ``` > > One thing that sticks out is "had to backup 1.55 GiB of 1.55 GiB > (compressed 1.55 GiB)..." when there is no compression, this should be > addressed in v2. > > > -- > Maximiliano > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel