From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 24B7D6104B
 for <pbs-devel@lists.proxmox.com>; Tue, 20 Oct 2020 08:13:24 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 139F5AA15
 for <pbs-devel@lists.proxmox.com>; Tue, 20 Oct 2020 08:12:54 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 0A053AA08
 for <pbs-devel@lists.proxmox.com>; Tue, 20 Oct 2020 08:12:53 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C23CB45E2E
 for <pbs-devel@lists.proxmox.com>; Tue, 20 Oct 2020 08:12:52 +0200 (CEST)
Date: Tue, 20 Oct 2020 08:12:30 +0200 (CEST)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, 
 Stefan Reiter <s.reiter@proxmox.com>
Message-ID: <1274295978.147.1603174351148@webmail.proxmox.com>
In-Reply-To: <20201019144523.24840-3-s.reiter@proxmox.com>
References: <20201019144523.24840-1-s.reiter@proxmox.com>
 <20201019144523.24840-3-s.reiter@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.4-Rev11
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.061 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup 3/3] fix #2988: allow
 verification after finishing a snapshot
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 20 Oct 2020 06:13:24 -0000


> +            let verify =3D |env: BackupEnvironment| {
> +                // we are done, so we can safely drop the snapshot guard=
 early
> +                // to allow the verify task to acquire it for itself

Instead, I would keep=C3=A4 the lock and use/expose "verify_backup_dir_no_l=
ock()". Is that
feasible?


> +                std::mem::drop(_snap_guard);
> +                if let Err(err) =3D env.verify_after_complete() {
> +                    env.log(format!(
> +                        "backup finished, but starting the requested ver=
ify task failed: {}",
> +                        err
> +                    ));
> +                }
> +            };
> +
>              match (res, env.ensure_finished()) {