From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA9E76046D for ; Wed, 2 Dec 2020 07:26:05 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D73FE176B7 for ; Wed, 2 Dec 2020 07:25:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 385CC176A6 for ; Wed, 2 Dec 2020 07:25:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 05A2344441 for ; Wed, 2 Dec 2020 07:25:34 +0100 (CET) Date: Wed, 2 Dec 2020 07:25:29 +0100 (CET) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Dominik Csapak Message-ID: <1214255675.462.1606890330472@webmail.proxmox.com> In-Reply-To: <20201201140148.21622-1-d.csapak@proxmox.com> References: <20201201140148.21622-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev14 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.112 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, pull.rs] Subject: [pbs-devel] applied: [PATCH proxmox-backup] client/pull: log how many groups to pull were found X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Dec 2020 06:26:06 -0000 applied > On 12/01/2020 3:01 PM Dominik Csapak wrote: > > > if no groups were found, the task log was very confusing as it > contained no real information why nothing was synced, e.g.: > > Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee' > Sync datastore 'local-datastore' from 'remote/datastore' > sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end > TASK OK > > this patch simply logs how many groups were found and are about to be synced: > > Starting datastore sync job 'remote:datastore:local-datastore:s-79412799-e6ee' > Sync datastore 'local-datastore' from 'remote/datastore' > found 0 groups to sync > sync job 'remote:datastore:local-datastore:s-79412799-e6ee' end > TASK OK > > Signed-off-by: Dominik Csapak > --- > src/client/pull.rs | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/client/pull.rs b/src/client/pull.rs > index 5403d873..ed8256fa 100644 > --- a/src/client/pull.rs > +++ b/src/client/pull.rs > @@ -498,6 +498,8 @@ pub async fn pull_store( > > let mut list: Vec = serde_json::from_value(result["data"].take())?; > > + worker.log(format!("found {} groups to sync", list.len())); > + > list.sort_unstable_by(|a, b| { > let type_order = a.backup_type.cmp(&b.backup_type); > if type_order == std::cmp::Ordering::Equal { > -- > 2.20.1 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel