From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8A70167B7F for ; Wed, 13 Jan 2021 17:05:33 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F2351373E for ; Wed, 13 Jan 2021 17:05:33 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 118D813731 for ; Wed, 13 Jan 2021 17:05:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D3D0F45D2D for ; Wed, 13 Jan 2021 17:05:28 +0100 (CET) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210113110654.17425-1-d.csapak@proxmox.com> From: Thomas Lamprecht Cc: Wolfgang Bumiller Message-ID: <11c952a6-616a-6bf9-0251-9d1dc94bac20@proxmox.com> Date: Wed, 13 Jan 2021 17:05:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Thunderbird/85.0 MIME-Version: 1.0 In-Reply-To: <20210113110654.17425-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL -0.068 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied-series: [PATCH proxmox-backup 0/6] tfa fixups X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 16:05:33 -0000 On 13.01.21 12:06, Dominik Csapak wrote: > fixed some of the more weird spacing/style issues i saw >=20 > there are still some issues, but maybe someone else can look at it: >=20 > * there is no gui for initial webauthn setup (which is mandatory) > * The text 'Copy Secret Value' is weird, but i could not come up with > something better for now > * on login, the text should not be 'OTP' for recovery keys, it should b= e > distinct, else it is very confusing > * the spacing on the login windows and deletion confirm window is still= > wrong > * the deletion confirm window has the title 'Confirm Password', but as > root@pam, there is no password field (better only "Conifrm"?) it is also weirdly formatted.. > we maybe can reuse our 'Safe Destroy Window' here? > * when i enter a wrong password, the error message is >=20 > AUTH_ERR (7) >=20 > which is not informational, and not consistent with our login. > * Some edit/add windows can be refactored using the Edit Window, > currently the functionality is duplicated across them > (addWebauthn, addTotp, etc.) > * The warning that there are only few recovery codes left has too many > warning icons (one should be enough) > * Sometimes i ran into an issue, where, if i have the recovery login > window open for too long, the code is not accepted. It was not very > clear to me if i can reuse that code again (i could) but that seems > to be bad ux, since normally a recovery code is not something i have > on hand, and it'll take a while until i found one. >=20 >=20 > Dominik Csapak (6): > ui: LoginView: remove not used viewModel > ui: config/TfaView: disable Remove button by default > ui: window/AddTfaRecovery: rewrite to a Proxmox.window.Edit > ui: window/AddTfaRecovery: fix style of TfaRecoveryShow window > ui: window/AddTotp: fix spacing styling of form fields > ui: window/{AddWebauthn,TfaEdit}: fix spacing/border of the windows >=20 > www/LoginView.js | 8 --- > www/config/TfaView.js | 1 + > www/window/AddTfaRecovery.js | 136 ++++++++++++-----------------------= > www/window/AddTotp.js | 81 ++++++++++----------- > www/window/AddWebauthn.js | 2 +- > www/window/TfaEdit.js | 1 - > 6 files changed, 86 insertions(+), 143 deletions(-) >=20 applied series, much thanks for those initial fixes! @Wolfgang, maybe you can also tackle a few of those when sending patches = for adding the initial setup part - after all the JS/gui part got pushed without any= real review by you ;P