From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <m.limbeck@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 28C5070616
 for <pbs-devel@lists.proxmox.com>; Fri, 22 Jul 2022 11:56:35 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 18C70196D
 for <pbs-devel@lists.proxmox.com>; Fri, 22 Jul 2022 11:56:05 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Fri, 22 Jul 2022 11:56:04 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8AC1D42742
 for <pbs-devel@lists.proxmox.com>; Fri, 22 Jul 2022 11:50:44 +0200 (CEST)
Message-ID: <1165df38-515e-5ace-9234-52c3cf2dc3af@proxmox.com>
Date: Fri, 22 Jul 2022 11:50:43 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Content-Language: en-US
To: Wolfgang Bumiller <w.bumiller@proxmox.com>,
 Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
References: <20220720142040.2140178-1-m.limbeck@proxmox.com>
 <443436b7-6b7e-e93b-b193-c3d8e1535a10@proxmox.com>
 <20220721114616.f74gqbo44xlo3pro@casey.proxmox.com>
From: Mira Limbeck <m.limbeck@proxmox.com>
In-Reply-To: <20220721114616.f74gqbo44xlo3pro@casey.proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.314 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-http] http: fix proxy authorization
 header to include type
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 22 Jul 2022 09:56:35 -0000

On 7/21/22 13:46, Wolfgang Bumiller wrote:
> On Thu, Jul 21, 2022 at 01:32:32PM +0200, Thomas Lamprecht wrote:
>> Am 20/07/2022 um 16:20 schrieb Mira Limbeck:
>>> and encode the username:password string as base64 [0]. This fixes the
>>> error 407 issue when using proxy authentication [1].
>> does this break setups that configured "Basic base64-encoded-pw" themselves though,
>> or was that never possible (e.g., due to schema not allowing that)?
> That would break other things. Eg. `ProxyConfig;:to_proxy_string` uses
> it to build "http://<authorization>@<host>" strings, so the "Basic "
> prefix and base64 encoding would break those.
>
> However, we also build such headers in src/client/simple.rs which should
> will need the same change I suppose?

Do we want to make the authentication scheme, here `Basic`, configurable?