From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 80412B8BC3 for ; Mon, 11 Mar 2024 15:12:21 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 64288A218 for ; Mon, 11 Mar 2024 15:12:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Mon, 11 Mar 2024 15:12:20 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1018E480AD for ; Mon, 11 Mar 2024 15:12:20 +0100 (CET) Date: Mon, 11 Mar 2024 15:12:19 +0100 (CET) From: Christian Ebner To: Proxmox Backup Server development discussion , =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= Message-ID: <1143354202.10816.1710166339391@webmail.proxmox.com> In-Reply-To: <1710159295.f7lna23xv8.astroid@yuna.none> References: <20240305092703.126906-1-c.ebner@proxmox.com> <20240305092703.126906-7-c.ebner@proxmox.com> <1710159295.f7lna23xv8.astroid@yuna.none> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev59 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.039 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC v2 pxar 06/36] encoder: move to stack based state tracking X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Mar 2024 14:12:21 -0000 > On 11.03.2024 14:21 CET Fabian Gr=C3=BCnbichler wrote: >=20 >=20 > nit: this could just use this.state_mut() >=20 >=20 > nit: this could just use self.state() >=20 Nope: Unfortunately the borrow check will not allow this in most of the cas= es, unless I overlooked something (that's why I had to opt for the ugly version instead of using the helper, introduced exactly for this reason). But I will double check these cases you mentioned, maybe during refactoring I missed some. >=20 > same here (and repeated quite a few times in the remainder of this > patch). it might be worth it to have another helper that gives you > (&mut output, &mut state) for payload or regular output? >=20 > e.g., something like this (or as two helpers dropping the bool > parameter): >=20 > + fn output_state(&mut self, payload: bool) -> io::Result<(&mut T, &mu= t EncoderState)> { > + Ok(( > + if payload { > + self.output.as_mut() > + } else { > + self.payload_output.as_mut().as_mut().unwrap() > + }, > + self.state > + .last_mut() > + .ok_or_else(|| io_format_err!("encoder state stack under= flow"))?, > + )) > + } >=20 Okay, yes that might be handy, thanks for the suggestion.