From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 94E729E9DA for ; Wed, 7 Jun 2023 09:40:52 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5B3AE3DD1A for ; Wed, 7 Jun 2023 09:40:52 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 7 Jun 2023 09:40:51 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 2B85B40A5C; Wed, 7 Jun 2023 09:40:51 +0200 (CEST) Date: Wed, 7 Jun 2023 09:40:50 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Maximiliano Sandoval Cc: Maximiliano Sandoval Message-ID: <1109818546.68.1686123650324@webmail.proxmox.com> In-Reply-To: <20230606123031.3133324-1-m.sandoval@proxmox.com> References: <20230606123031.3133324-1-m.sandoval@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev45 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.382 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH] fix #4638: proxmox-backup-client: status: guard against div by zero X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jun 2023 07:40:52 -0000 Please can you set the correct email address in git config? Otherwise the patch looks ok for me, thanks! > On 06/06/2023 2:30 PM CEST Maximiliano Sandoval wrote: > > > From: Maximiliano Sandoval > > We throw an error if the value for total is zero. > > Signed-off-by: Maximiliano Sandoval > --- > proxmox-backup-client/src/main.rs | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/proxmox-backup-client/src/main.rs b/proxmox-backup-client/src/main.rs > index 55198108..5a804d95 100644 > --- a/proxmox-backup-client/src/main.rs > +++ b/proxmox-backup-client/src/main.rs > @@ -1590,9 +1590,12 @@ async fn status(param: Value) -> Result { > let v = v.as_u64().unwrap(); > let total = record["total"].as_u64().unwrap(); > let roundup = total / 200; > - let per = ((v + roundup) * 100) / total; > - let info = format!(" ({} %)", per); > - Ok(format!("{} {:>8}", v, info)) > + if let Some(per) = ((v + roundup) * 100).checked_div(total) { > + let info = format!(" ({} %)", per); > + Ok(format!("{} {:>8}", v, info)) > + } else { > + bail!("Cannot render total percentage: denominator is zero"); > + } > }; > > let options = default_table_format_options() > -- > 2.30.2 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel