From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 6992A6AD43 for ; Wed, 17 Feb 2021 10:12:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 59E121FC81 for ; Wed, 17 Feb 2021 10:12:07 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id E71751FC74 for ; Wed, 17 Feb 2021 10:12:06 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id AA2AA41BA3 for ; Wed, 17 Feb 2021 10:12:06 +0100 (CET) Date: Wed, 17 Feb 2021 10:11:22 +0100 (CET) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Stefan Reiter Message-ID: <1050366057.3056.1613553083538@webmail.proxmox.com> In-Reply-To: <20210216170710.31767-11-s.reiter@proxmox.com> References: <20210216170710.31767-1-s.reiter@proxmox.com> <20210216170710.31767-11-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev16 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.122 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-client.rs, snapshot.rs, key.rs, catalog.rs, mod.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup 10/22] proxmox_client_tools: extract 'key' from client module X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 09:12:37 -0000 > On 02/16/2021 6:06 PM Stefan Reiter wrote: > > > To be used by other command line tools. Requires moving XDG helpers as > well, which find their place in the tools module quite cozily IMHO. > > Signed-off-by: Stefan Reiter > --- > src/bin/proxmox-backup-client.rs | 440 +----------------- > src/bin/proxmox_backup_client/catalog.rs | 4 +- > src/bin/proxmox_backup_client/mod.rs | 30 -- > src/bin/proxmox_backup_client/snapshot.rs | 3 +- > .../key.rs | 440 +++++++++++++++++- > src/bin/proxmox_client_tools/mod.rs | 30 +- > 6 files changed, 474 insertions(+), 473 deletions(-) > rename src/bin/{proxmox_backup_client => proxmox_client_tools}/key.rs (52%) Also, this diff hides most code behind the rename. This is extremely dangerous, and should be avoided (use an extra patch for renames).