From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 687AA71E2C for ; Fri, 9 Apr 2021 17:55:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 539DB96B9 for ; Fri, 9 Apr 2021 17:54:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7F16A96AC for ; Fri, 9 Apr 2021 17:54:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 4C44B41622 for ; Fri, 9 Apr 2021 17:54:48 +0200 (CEST) Date: Fri, 9 Apr 2021 17:54:37 +0200 (CEST) From: Dietmar Maurer To: Proxmox Backup Server development discussion , Dominik Csapak Message-ID: <1038366645.1985.1617983677776@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.5-Rev5 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.111 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com] Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] tape/file_formats/blocked_reader: restore EOD behaviour X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2021 15:55:19 -0000 IMHO this is the wrong fix. Instead, we want to catch ENOSPC. > On 04/09/2021 4:18 PM Dominik Csapak wrote: > > > before commit > 0db571249 ("tape: introduce BlockRead") > > we did not return an error on EOD, but changed that. > The rest of the code assumes to be able to read there and not > encounter an error, so that change resulted in > > 'no space left on device' errors on all tasks/api calls where we > would read to the end of the tape, e.g. a restore, read label on an > empty tape, etc. > > This patch restores the previous behaviour. > > Signed-off-by: Dominik Csapak > --- > not sure if this is the intended behavior, but fixes many > 'no space on device' errors we encounter currently > > if the intention was that we catch the enospc error explicitely on the > caller side, we would have to invent our own error type here, > as this results in an io::Error with ErrorKind::Other (makes matching a bit weird) > > src/tape/file_formats/blocked_reader.rs | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/src/tape/file_formats/blocked_reader.rs b/src/tape/file_formats/blocked_reader.rs > index 3df84a1b..e7dfa90a 100644 > --- a/src/tape/file_formats/blocked_reader.rs > +++ b/src/tape/file_formats/blocked_reader.rs > @@ -111,12 +111,9 @@ impl BlockedReader { > } > Ok(true) > } > - Ok(BlockReadStatus::EndOfFile) => { > + Ok(BlockReadStatus::EndOfFile) | Ok(BlockReadStatus::EndOfStream)=> { > Ok(false) > } > - Ok(BlockReadStatus::EndOfStream) => { > - return Err(std::io::Error::from_raw_os_error(nix::errno::Errno::ENOSPC as i32)); > - } > Err(err) => { > Err(err) > } > -- > 2.20.1 > > > > _______________________________________________ > pbs-devel mailing list > pbs-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel