From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 56F121FF2F6 for ; Wed, 29 May 2024 12:23:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0C7F62F3D; Wed, 29 May 2024 12:23:25 +0200 (CEST) Date: Wed, 29 May 2024 12:22:51 +0200 (CEST) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Proxmox Backup Server development discussion , Dietmar Maurer Message-ID: <103715843.2056.1716978171391@webmail.proxmox.com> In-Reply-To: <20240529095502.938695-1-dietmar@proxmox.com> References: <20240529095502.938695-1-dietmar@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev64 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.059 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [config.rs] Subject: Re: [pbs-devel] [PATCH proxmox v2] sys: pass create options as reference X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" > Dietmar Maurer hat am 29.05.2024 11:55 CEST geschrieben: > > > Signed-off-by: Dietmar Maurer > --- > > Changes in v2: change everywhere, so "cargo build --all --all-features" works again what about proxmox-backup (and potentially other crates using it)? I guess we could make a note for the next proxmox-sys bump we do for other reasons, but bumping half the world just for this seems a lot of work for little gain? > > proxmox-acme-api/src/account_config.rs | 2 +- > proxmox-acme-api/src/config.rs | 2 +- > proxmox-openid/src/auth_state.rs | 4 ++-- > .../src/filesystem_helpers.rs | 10 +++++----- > proxmox-rest-server/src/api_config.rs | 4 ++-- > proxmox-rest-server/src/daemon.rs | 2 +- > proxmox-rest-server/src/file_logger.rs | 2 +- > proxmox-rest-server/src/lib.rs | 2 +- > proxmox-rest-server/src/worker_task.rs | 10 +++++----- > proxmox-rrd/src/cache.rs | 4 ++-- > proxmox-rrd/src/cache/journal.rs | 4 ++-- > proxmox-rrd/src/cache/rrd_map.rs | 4 ++-- > proxmox-rrd/src/rrd.rs | 2 +- > proxmox-subscription/src/files.rs | 4 ++-- > proxmox-sys/src/fs/dir.rs | 20 +++++++++---------- > proxmox-sys/src/fs/file.rs | 8 ++++---- > proxmox-sys/src/logrotate.rs | 2 +- > .../src/dns/resolv_conf.rs | 2 +- > 18 files changed, 44 insertions(+), 44 deletions(-) > [..] > diff --git a/proxmox-subscription/src/files.rs b/proxmox-subscription/src/files.rs > index 37008f4a..f0ff9bf4 100644 > --- a/proxmox-subscription/src/files.rs > +++ b/proxmox-subscription/src/files.rs > @@ -127,7 +127,7 @@ pub fn write_subscription>( > format!("{}\n{}\n{}\n", info.key.as_ref().unwrap(), csum, encoded) > }; > > - replace_file(path, raw.as_bytes(), file_opts, true)?; > + replace_file(path, raw.as_bytes(), &file_opts, true)?; > > Ok(()) > } > @@ -152,7 +152,7 @@ pub fn update_apt_auth>( this at least itself takes it as non-ref, shouldn't that be updated as well then? > let conf = format!("machine {url}\n login {}\n password {}\n", key, password,); > > // we use a namespaced .conf file, so just overwrite.. > - replace_file(path, conf.as_bytes(), file_opts, true) > + replace_file(path, conf.as_bytes(), &file_opts, true) > .map_err(|e| format_err!("Error saving apt auth config - {}", e))?; > } > _ => match std::fs::remove_file(path) { _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel