From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 9E774BAADB for ; Fri, 15 Dec 2023 09:45:30 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7F8BA1F3A5 for ; Fri, 15 Dec 2023 09:45:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Fri, 15 Dec 2023 09:45:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 474AD47965 for ; Fri, 15 Dec 2023 09:45:29 +0100 (CET) Message-ID: <0fd7c3ba-7c5f-470b-857c-01230a71633d@proxmox.com> Date: Fri, 15 Dec 2023 09:45:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Lukas Wagner , Proxmox Backup Server development discussion References: <20231204100414.152770-1-p.hufnagl@proxmox.com> <62cc0327-cae3-4f4d-a5c0-259dae45efdd@proxmox.com> From: Philipp Hufnagl In-Reply-To: <62cc0327-cae3-4f4d-a5c0-259dae45efdd@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.043 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH proxmox-backup v4 0/3] fix #4315: datastore: Exclude entries from sync X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Dec 2023 08:45:30 -0000 On 12/14/23 17:22, Lukas Wagner wrote: > Hi, > > quickly tested these changes. Seems to work mostly fine, however ... > > On 12/4/23 11:04, Philipp Hufnagl wrote: >> This allows to use Group Filter for sync jobs so matches can not >> just be >> included but also excluded. For this the "group-filter" configuration >> syntax has been extended with an optional "behaviour" parameter. >> this can be "include" or "exclude". First, all include filter will be >> applied, then all exclude filter. If no include filters exist, all will >> be considered included. >> >> Signed-off-by: Philipp Hufnagl >> --- >> >> Changes since v3: >>   * increase size of delete icon >>   * include all when only exclude filter exist > > ... this version changes the behavior when only INCLUDES exist... >  - before: No groups, except those which match the include filters >  - with these patches: All groups are included > > Thats strange. I actually tested this. Ill check againn and send a new patch.