From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 940E175958 for ; Tue, 13 Jul 2021 11:56:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7D0791F0BD for ; Tue, 13 Jul 2021 11:56:20 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id A96711F0AD for ; Tue, 13 Jul 2021 11:56:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 68EBD40D3B for ; Tue, 13 Jul 2021 11:56:18 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20210713091125.2064985-1-d.csapak@proxmox.com> From: Dietmar Maurer Message-ID: <0f381d8d-f145-7986-804a-85b3ccffcf7f@proxmox.com> Date: Tue, 13 Jul 2021 11:56:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210713091125.2064985-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-SPAM-LEVEL: Spam detection results: 0 AWL 0.922 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] applied: [PATCH proxmox-backup 1/2] chunk_store/insert_chunk: add more information to file errors X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Jul 2021 09:56:50 -0000 applied On 7/13/21 11:11 AM, Dominik Csapak wrote: > otherwise this context is missing in some tasks (e.g. tape restore) > and it is unclear where it came from > > Signed-off-by: Dominik Csapak > --- > pbs-datastore/src/chunk_store.rs | 18 ++++++++++++++++-- > 1 file changed, 16 insertions(+), 2 deletions(-) > > diff --git a/pbs-datastore/src/chunk_store.rs b/pbs-datastore/src/chunk_store.rs > index ddf0a769..361cc9a2 100644 > --- a/pbs-datastore/src/chunk_store.rs > +++ b/pbs-datastore/src/chunk_store.rs > @@ -401,12 +401,26 @@ impl ChunkStore { > let mut tmp_path = chunk_path.clone(); > tmp_path.set_extension("tmp"); > > - let mut file = std::fs::File::create(&tmp_path)?; > + let mut file = std::fs::File::create(&tmp_path).map_err(|err| { > + format_err!( > + "creating temporary chunk on store '{}' failed for {} - {}", > + self.name, > + digest_str, > + err > + ) > + })?; > > let raw_data = chunk.raw_data(); > let encoded_size = raw_data.len() as u64; > > - file.write_all(raw_data)?; > + file.write_all(raw_data).map_err(|err| { > + format_err!( > + "writing temporary chunk on store '{}' failed for {} - {}", > + self.name, > + digest_str, > + err > + ) > + })?; > > if let Err(err) = std::fs::rename(&tmp_path, &chunk_path) { > if std::fs::remove_file(&tmp_path).is_err() { /* ignore */ }