From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 8F2EF1FF140 for ; Fri, 10 Apr 2026 07:55:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D0EBD13B0D; Fri, 10 Apr 2026 07:56:12 +0200 (CEST) Message-ID: <0ea651d8-a4a7-4232-91aa-82c401b0219d@proxmox.com> Date: Fri, 10 Apr 2026 07:56:08 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: applied: [PATCH proxmox-backup v8 00/17] partially fix #6563: add s3 counter for statistics and notifications To: Thomas Lamprecht , pbs-devel@lists.proxmox.com References: <20260402105333.463088-1-c.ebner@proxmox.com> <177578214248.2697034.10511094955518196902.b4-ty@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <177578214248.2697034.10511094955518196902.b4-ty@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775800499521 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.068 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6HMPXJXIJQQAKGZOPKGLHBF4HMSH3K5J X-Message-ID-Hash: 6HMPXJXIJQQAKGZOPKGLHBF4HMSH3K5J X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On 4/10/26 2:48 AM, Thomas Lamprecht wrote: > On Thu, 02 Apr 2026 12:53:16 +0200, Christian Ebner wrote: >> This patch series implements request and traffic counters for the s3 >> client, being shared as atomic counters via shared memory and mmapping >> across all s3-client instances. >> >> The shared counters are instantiated on demand for individual >> datastores with s3 backend on s3 client instantiation and stored as >> part of the datastore implementation by loading the mmapped file on >> datastore creation, being cached for further access. Counter threshold >> values can be defined in the datastore options, allowing to send >> notifications via the notification system if counters exceeded the set >> threshold values. Further, a per-datastore schedule can be configured >> to reset the counters with given interval. >> >> [...] > > Applied, with a few follow-ups that should address your own and Dominik > findings, thanks! Huge thanks for the code cleanups! Especially the changes with respect to the requests threshold callback make the code way better!