From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8BEB46475F for ; Mon, 20 Jul 2020 16:48:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7B9F7F20E for ; Mon, 20 Jul 2020 16:48:29 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 48E94F202 for ; Mon, 20 Jul 2020 16:48:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 104DF430DA for ; Mon, 20 Jul 2020 16:48:28 +0200 (CEST) To: Proxmox Backup Server development discussion , Dominik Csapak References: <20200717133917.4621-1-d.csapak@proxmox.com> From: Thomas Lamprecht Message-ID: <0e2a5a75-be65-73e0-acbb-ead3a31532c4@proxmox.com> Date: Mon, 20 Jul 2020 16:48:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:79.0) Gecko/20100101 Thunderbird/79.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-SPAM-LEVEL: Spam detection results: 0 AWL 0.010 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.001 Looks like a legit reply (A) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup 1/2] api2/status: fix estimation bug X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jul 2020 14:48:59 -0000 On 20.07.20 16:37, Dominik Csapak wrote: > On 7/20/20 11:36 AM, Thomas Lamprecht wrote: >> On 17.07.20 15:39, Dominik Csapak wrote: >>> when a datastore has enough data to calculate the estimated full date= , >>> but always has exactly the same usage, the factor b of the regression= >>> is '0' >>> >>> return 0 for that case so that the gui can show 'never' instead of >>> 'not enough data' >>> >>> Signed-off-by: Dominik Csapak >>> --- >>> =C2=A0 src/api2/status.rs | 2 ++ >>> =C2=A0 1 file changed, 2 insertions(+) >>> >>> diff --git a/src/api2/status.rs b/src/api2/status.rs >>> index 34e0505..4f98543 100644 >>> --- a/src/api2/status.rs >>> +++ b/src/api2/status.rs >>> @@ -161,6 +161,8 @@ fn datastore_status( >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 if b !=3D 0.0 { >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 let estimate =3D (1.0 - a) / b; >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 entry["estimated-full-date"] =3D Value::fr= om(estimate.floor() as u64); >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } e= lse { >>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 entry["estimated-full-date"] =3D Value::from(0); >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0 } >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 } >>> >> >> nit and asking mostly out of interest, but wouldn't it be more "idomat= ic rust" if this >> was written like: >> >> entry["estimated-full-date"] =3D if b !=3D 0.0 { >> =C2=A0=C2=A0=C2=A0=C2=A0 let estimate =3D (1.0 - a) / b; >> =C2=A0=C2=A0=C2=A0=C2=A0 Value::from(estimate.floor() as u64) >> } else { >> =C2=A0=C2=A0=C2=A0=C2=A0 Value::from(0) >> } >> >> anyway, looks OK to me from a quick look. >> >=20 > yes, probably... i personally find those multiline let foo =3D if {..} = statements a bit harder to read... >=20 >=20 > should i send a v2? no, just for that definitively not.