From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9])
	by lore.proxmox.com (Postfix) with ESMTPS id 2E1E01FF137
	for <inbox@lore.proxmox.com>; Tue, 17 Feb 2026 10:39:46 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
	by firstgate.proxmox.com (Proxmox) with ESMTP id 2FC9131558;
	Tue, 17 Feb 2026 10:40:37 +0100 (CET)
Message-ID: <0dc879de-f02f-47db-b9ed-226b6662eef3@proxmox.com>
Date: Tue, 17 Feb 2026 10:40:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v6 proxmox-backup 07/18] datastore: verify that chunk_size
 is a power of two
To: Robert Obkircher <r.obkircher@proxmox.com>, pbs-devel@lists.proxmox.com
References: <20260210150642.469670-1-r.obkircher@proxmox.com>
 <20260210150642.469670-8-r.obkircher@proxmox.com>
 <376f156b-4343-4be4-8653-2b58fff4abd0@proxmox.com>
Content-Language: en-US, de-DE
From: Christian Ebner <c.ebner@proxmox.com>
In-Reply-To: <376f156b-4343-4be4-8653-2b58fff4abd0@proxmox.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1771321225622
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.047 Adjusted score from AWL reputation of From:
 address
	BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment
	RCVD_IN_VALIDITY_CERTIFIED_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_RPBL_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	RCVD_IN_VALIDITY_SAFE_BLOCKED  0.001 ADMINISTRATOR NOTICE: The query to
 Validity was blocked.  See
 https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
 information.
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: MM4G3A32KETI6OCEVACBBCA53CRRMKSH
X-Message-ID-Hash: MM4G3A32KETI6OCEVACBBCA53CRRMKSH
X-MailFrom: c.ebner@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On 2/17/26 10:13 AM, Robert Obkircher wrote:
> 
> On 2/10/26 16:05, Robert Obkircher wrote:
>> Guarantee that the bitmasks used to compute the modulo actually yield
>> the correct value and implicitly guard against divisions by zero.
> 
> The bitmask trick for faster modulo operations is used by the Reader
> [1] and Writer [2].
> 
> [1]
> https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-datastore/src/fixed_index.rs;h=6c3be2d492d3b15a04b2d4356d7183d75c349f26;hb=HEAD#l210
> 
> [2]
> https://git.proxmox.com/?p=proxmox-backup.git;a=blob;f=pbs-datastore/src/fixed_index.rs;h=6c3be2d492d3b15a04b2d4356d7183d75c349f26;hb=HEAD#l380
> 
> 
> [..]
Thanks for the pointer, the information where these operations are being 
used should be folded into the commit message, that can however be done 
when applying if nothing else comes up.