From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6394C1FF16C for ; Tue, 3 Sep 2024 14:38:55 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4355E9B48; Tue, 3 Sep 2024 14:39:29 +0200 (CEST) Message-ID: <0cb5e480-27dd-4934-9208-a9c5b147d119@proxmox.com> Date: Tue, 3 Sep 2024 14:38:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Wolfgang Bumiller References: <20240808114203.187189-1-c.ebner@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v2 proxmox-backup] client: catalog shell: avoid navigating below archive root X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Cc: pbs-devel@lists.proxmox.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 8/30/24 10:00, Wolfgang Bumiller wrote: > On Thu, Aug 08, 2024 at 01:42:03PM GMT, Christian Ebner wrote: >> Avoid to underflow the catalogs shell position stack by navigating >> below the archives root directory into the catalog root. Otherwise >> the shell will panic, as the root entry is always expected to be >> present. >> >> This threats the archive root directory as being it's own parent >> directory, mimicking the behaviour of most common shells. >> >> Signed-off-by: Christian Ebner >> --- >> Encountered while implementing the catalog shell for the split pxar >> archive case. >> >> Without this additional check, a `cd ..` in the pxar archive root of >> the catalog shell will panic. > > > What about `cd ../../..` when *not* at a root, would we now ignore this > without any error messages? True, the case where the current working directory is not the root directory is not handled correctly as is. Will send a new version of the patch fixing that. Thanks a lot! _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel