From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id CB7C01FF13B for ; Wed, 25 Mar 2026 17:37:14 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0051730EC3; Wed, 25 Mar 2026 17:37:35 +0100 (CET) Message-ID: <0c0c7dbc-cc07-4f67-b879-851410f0d0be@proxmox.com> Date: Wed, 25 Mar 2026 17:36:59 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-backup] fix #7412: ui: dashboard: persist datastore usage column state To: David Riley , pbs-devel@lists.proxmox.com References: <20260324093425.38594-1-d.riley@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <20260324093425.38594-1-d.riley@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1774456572604 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.060 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IKERR6VSZS6AZOUS2UFPHH4VSHO5VFEB X-Message-ID-Hash: IKERR6VSZS6AZOUS2UFPHH4VSHO5VFEB X-MailFrom: c.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the patch! Only one nit inline, which may however be considered when applying. Tested state is maintained on page refresh and survives a logout/login. On 3/24/26 10:34 AM, David Riley wrote: > Store the state of the columns for the Datastore Usage Dashboard. > Ensures the column configuration is maintained across > page reloads and navigations instead of resetting to the default view. > > Signed-off-by: David Riley > --- Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=7412 Reviewed-by: Christian Ebner Tested-by: Christian Ebner > www/dashboard/DataStoreStatistics.js | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js > index c210d24d..7a33f49d 100644 > --- a/www/dashboard/DataStoreStatistics.js > +++ b/www/dashboard/DataStoreStatistics.js > @@ -55,6 +55,8 @@ Ext.define('PBS.DatastoreStatistics', { > > title: gettext('Datastore Usage'), > disableSelection: true, > + stateful: true, > + stateId: 'dashboard-grid-datastore-usage', nit: other occurrences of `stateId` for grids in the PBS code base seem to typically follow the form `grid-{component-name}`, so this should be `grid-datastore-statistics`. > > emptyText: gettext('No Data'), >