From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8DB56B8D20 for ; Wed, 6 Dec 2023 14:37:55 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5D4162940 for ; Wed, 6 Dec 2023 14:37:25 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Dec 2023 14:37:24 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 734C442547 for ; Wed, 6 Dec 2023 14:37:24 +0100 (CET) Message-ID: <0bbf284e-0f77-4ca1-aefc-dc31b3932f67@proxmox.com> Date: Wed, 6 Dec 2023 14:37:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox Backup Server development discussion , Christian Ebner References: <20231206113101.139743-1-c.ebner@proxmox.com> From: Gabriel Goller In-Reply-To: <20231206113101.139743-1-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.157 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup] ui: warn of missing gc-schedule, prune/verify jobs X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Dec 2023 13:37:55 -0000 LGTM! Tested-by: Gabriel Goller Reviewed-by: Gabriel Goller On 12/6/23 12:31, Christian Ebner wrote: > Warn about a missing garbage collection schedule, prune job or verify > job configurations in the datastore's summary panel. > > Show the number of prune/verify job configurations, if there are jobs > configured. > > Signed-off-by: Christian Ebner > --- > changes since version 2: > - move message string initialization to controllers `init` function > > changes since version 1: > - add check mark icon for configured jobs/schedule > - add question mark icon for unknown configuration state > - fix typo in garbage collection variable name > - add missing trailing commas found by pve-eslint > - refactor message initialization to allow to use format helper > functions > www/datastore/Summary.js | 96 ++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 96 insertions(+) > > [..]