From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1C7369A1EE for ; Thu, 12 Oct 2023 15:08:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F32AB139D8 for ; Thu, 12 Oct 2023 15:07:59 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 12 Oct 2023 15:07:57 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 885F343EC6; Thu, 12 Oct 2023 15:07:57 +0200 (CEST) Message-ID: <0ba969ca-6b72-46d7-b622-94e0e21acde9@proxmox.com> Date: Thu, 12 Oct 2023 15:07:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Proxmox Backup Server development discussion , Philipp Hufnagl References: <20231003140720.1635670-1-p.hufnagl@proxmox.com> From: Dominik Csapak In-Reply-To: <20231003140720.1635670-1-p.hufnagl@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.011 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [snapshot.rs] Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #4971: client: Improve output on successful snapshot deletion X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Oct 2023 13:08:00 -0000 LGTM Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak On 10/3/23 16:07, Philipp Hufnagl wrote: > When a snapshot gets deleted (forgotten), the proxmox backup client > currently returns returns > "Result: { > "data": null > }" > > This feedback may confuse users therefore this patch changes the output > to > > "Successfully deleted snapshot " > > Signed-off-by: Philipp Hufnagl > --- > proxmox-backup-client/src/snapshot.rs | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/proxmox-backup-client/src/snapshot.rs b/proxmox-backup-client/src/snapshot.rs > index 4ca8015f..1d985a2e 100644 > --- a/proxmox-backup-client/src/snapshot.rs > +++ b/proxmox-backup-client/src/snapshot.rs > @@ -188,13 +188,14 @@ async fn forget_snapshots(param: Value) -> Result { > > let path = format!("api2/json/admin/datastore/{}/snapshots", repo.store()); > > - let result = client > + client > .delete(&path, Some(snapshot_args(&backup_ns, &snapshot)?)) > .await?; > > record_repository(&repo); > > - Ok(result) > + println!("Successfully deleted snapshot {}", snapshot); > + Ok(Value::Null) > } > > #[api(